Re: [Xen-devel] [PATCH 1/5] x86emul: support UMIP

2016-09-30 Thread Jan Beulich
>>> On 30.09.16 at 14:27, wrote: > On 30/09/16 13:23, Jan Beulich wrote: > On 30.09.16 at 12:32, wrote: >>> On 08/09/16 14:42, Jan Beulich wrote: @@ -1484,6 +1485,17 @@ static bool is_aligned(enum x86_segment return !((reg.base + offs) & (size - 1)); } +static

Re: [Xen-devel] [PATCH 1/5] x86emul: support UMIP

2016-09-30 Thread Andrew Cooper
On 30/09/16 13:23, Jan Beulich wrote: On 30.09.16 at 12:32, wrote: >> On 08/09/16 14:42, Jan Beulich wrote: >>> @@ -1484,6 +1485,17 @@ static bool is_aligned(enum x86_segment >>> return !((reg.base + offs) & (size - 1)); >>> } >>> >>> +static bool is_umip(struct x86_emulate_ctxt *ctxt

Re: [Xen-devel] [PATCH 1/5] x86emul: support UMIP

2016-09-30 Thread Jan Beulich
>>> On 30.09.16 at 12:32, wrote: > On 08/09/16 14:42, Jan Beulich wrote: >> @@ -1484,6 +1485,17 @@ static bool is_aligned(enum x86_segment >> return !((reg.base + offs) & (size - 1)); >> } >> >> +static bool is_umip(struct x86_emulate_ctxt *ctxt, >> +const struct x86_em

Re: [Xen-devel] [PATCH 1/5] x86emul: support UMIP

2016-09-30 Thread Andrew Cooper
On 08/09/16 14:42, Jan Beulich wrote: > To make this complete, also add support for SLDT and STR. Note that by > just looking at the guest CR4 bit, this is independent of actually > making available the UMIP feature to guests. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/x86_emulate/x86_e