On Wed, 2014-11-05 at 14:43 +, Ian Jackson wrote:
Sorry to be a bit late to the game, do I win a prize? ;-)
[...]
> + Usually, don't use: Instead, use (see libxl_internal.h):
> + libxl__log[v] LOG, LOGE, LOGEV
> + libxl__sprintf GCSPRINTF
> + libxl__*alloc et al.
Ian Campbell writes ("Re: [PATCH 1/4] libxl: CODING_STYLE: Much new material"):
> On Wed, 2014-11-05 at 14:43 +, Ian Jackson wrote:
> > +The following local variable names should be used where applicable:
> > +
> > + int rc;/* a libxl error code - and not anything else */
> > + int r;
On Wed, 2014-11-05 at 14:43 +, Ian Jackson wrote:
> Discuss:
>
> Memory allocation
> Conventional variable names
> Convenience macros
> Error handling
> Idempotent data structure construction/destruction
> Asynchronous/long-running operations
>
> Signed-off-by: Ian Jac