Re: [Xen-devel] [PATCH 1/3] xl: free config_data on error in domain_create

2016-02-19 Thread Ian Campbell
On Fri, 2016-02-19 at 16:08 +, Ian Campbell wrote: >              /* allocate space for the extra config plus two EOLs > > > plus > > > \0 */ > > > @@ -6525,6 +6526,7 @@ int main_networkattach(int argc, char **argv) > > >  } > > >   > > >  xlu_cfg_destroy(config); > > > +config = NU

Re: [Xen-devel] [PATCH 1/3] xl: free config_data on error in domain_create

2016-02-19 Thread Ian Campbell
On Fri, 2016-02-19 at 16:02 +, Ian Jackson wrote: > Ian Campbell writes ("[PATCH 1/3] xl: free config_data on error in > domain_create"): > > CID: 1055898 > ... > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > > index d5a397a..e819ee6 100644 > > --- a/tools/libxl/xl_cmdimp

Re: [Xen-devel] [PATCH 1/3] xl: free config_data on error in domain_create

2016-02-19 Thread Ian Jackson
Ian Campbell writes ("[PATCH 1/3] xl: free config_data on error in domain_create"): > CID: 1055898 ... > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index d5a397a..e819ee6 100644 > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -2795,6 +2795,7 @@ static