Re: [Xen-devel] [PATCH 05/22] mini-os: add boot code for HVMlite support

2016-08-23 Thread Juergen Gross
On 23/08/16 22:51, Samuel Thibault wrote: > Hello, > > It looks good, there is just: > > Juergen Gross, on Tue 23 Aug 2016 17:15:51 +0200, wrote: >> +.macro PTES prot, addr, incr, idx, end > > Please document what prot, addr, incr, idx, end represent precisely. Okay. > >> +.if

Re: [Xen-devel] [PATCH 05/22] mini-os: add boot code for HVMlite support

2016-08-23 Thread Samuel Thibault
Hello, It looks good, there is just: Juergen Gross, on Tue 23 Aug 2016 17:15:51 +0200, wrote: > +.macro PTES prot, addr, incr, idx, end Please document what prot, addr, incr, idx, end represent precisely. > +.ifgt \end-\idx-32 > +PTES \prot, \addr, \incr, \idx, "(\idx+32