Re: [Xen-devel] [PATCH 05/16] xen: sched: move pCPU initialization in an helper

2016-03-24 Thread Dario Faggioli
On Wed, 2016-03-23 at 17:51 +, George Dunlap wrote: > On 18/03/16 19:04, Dario Faggioli wrote: > > --- a/xen/common/sched_credit.c > > +++ b/xen/common/sched_credit.c > > @@ -542,16 +542,11 @@ csched_alloc_pdata(const struct scheduler > > *ops, int cpu) > >  } > >   > >  static void > > -csched

Re: [Xen-devel] [PATCH 05/16] xen: sched: move pCPU initialization in an helper

2016-03-23 Thread George Dunlap
On 23/03/16 17:51, George Dunlap wrote: > On 18/03/16 19:04, Dario Faggioli wrote: >> That will turn out useful in following patches, where such >> code will need to be called more than just once. Create an >> helper now, and move the code there, to avoid mixing code >> motion and functional change

Re: [Xen-devel] [PATCH 05/16] xen: sched: move pCPU initialization in an helper

2016-03-23 Thread George Dunlap
On 18/03/16 19:04, Dario Faggioli wrote: > That will turn out useful in following patches, where such > code will need to be called more than just once. Create an > helper now, and move the code there, to avoid mixing code > motion and functional changes later. > > In Credit2, some style cleanup i