Re: [Xen-devel] [PATCH 04/10] x86/cpuid: Handle leaf 0x4 in guest_cpuid()

2017-02-21 Thread Andrew Cooper
On 22/02/17 07:23, Jan Beulich wrote: On 21.02.17 at 18:35, wrote: >> On 21/02/17 17:16, Jan Beulich wrote: >> On 20.02.17 at 12:00, wrote: --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -163,6 +163,9 @@ static void recalculate_xstate(struct cpuid_policy *p)

Re: [Xen-devel] [PATCH 04/10] x86/cpuid: Handle leaf 0x4 in guest_cpuid()

2017-02-21 Thread Jan Beulich
>>> On 21.02.17 at 18:35, wrote: > On 21/02/17 17:16, Jan Beulich wrote: > On 20.02.17 at 12:00, wrote: >>> --- a/xen/arch/x86/cpuid.c >>> +++ b/xen/arch/x86/cpuid.c >>> @@ -163,6 +163,9 @@ static void recalculate_xstate(struct cpuid_policy *p) >>> */ >>> static void recalculate_misc(struc

Re: [Xen-devel] [PATCH 04/10] x86/cpuid: Handle leaf 0x4 in guest_cpuid()

2017-02-21 Thread Andrew Cooper
On 21/02/17 17:16, Jan Beulich wrote: On 20.02.17 at 12:00, wrote: >> --- a/xen/arch/x86/cpuid.c >> +++ b/xen/arch/x86/cpuid.c >> @@ -163,6 +163,9 @@ static void recalculate_xstate(struct cpuid_policy *p) >> */ >> static void recalculate_misc(struct cpuid_policy *p) >> { >> +/* Leaves

Re: [Xen-devel] [PATCH 04/10] x86/cpuid: Handle leaf 0x4 in guest_cpuid()

2017-02-21 Thread Jan Beulich
>>> On 20.02.17 at 12:00, wrote: > --- a/xen/arch/x86/cpuid.c > +++ b/xen/arch/x86/cpuid.c > @@ -163,6 +163,9 @@ static void recalculate_xstate(struct cpuid_policy *p) > */ > static void recalculate_misc(struct cpuid_policy *p) > { > +/* Leaves with subleaf unions. */ > +p->basic.raw[0