Re: [Xen-devel] [PATCH 03/17] oxenstored: honour XEN_LOG_DIR defined by configure

2016-06-13 Thread Wei Liu
On Mon, Jun 13, 2016 at 11:07:19AM +0100, Andrew Cooper wrote: > On 13/06/16 08:49, Wei Liu wrote: > > We generate a corresponding constant (in lower case) in paths.ml. Use > > that in source code to get rid of hard-coded path. > > > > Signed-off-by: Wei Liu > > Acked-by: David Scot > > You have

Re: [Xen-devel] [PATCH 03/17] oxenstored: honour XEN_LOG_DIR defined by configure

2016-06-13 Thread Andrew Cooper
On 13/06/16 08:49, Wei Liu wrote: > We generate a corresponding constant (in lower case) in paths.ml. Use > that in source code to get rid of hard-coded path. > > Signed-off-by: Wei Liu > Acked-by: David Scot You have dropped a 't'. You should also note in the commit message that this alters wh