Hi Julien,
On 23 March 2017 at 19:46, Julien Grall wrote:
>>> It makes little sense to hardcode the MMIO region and not the SPI. Also,
>>> I
>>> would rather avoid to introduce new HVM_PARAM when not necessary. So
>>> hardcoding the value looks more sensible to me.
>>>
>> So for reserving a SPI f
On 23/03/17 09:14, Bhupinder Thakur wrote:
.Hi Julien,
Hi Bhupinder,
On 5 March 2017 at 17:42, Julien Grall wrote:
Hi Bhupinder,
On 21/02/17 11:25, Bhupinder Thakur wrote:
diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c
Lastly, what if vpl011_write_data is returning an error
Hi Bhupinder,
On 23/03/17 09:44, Bhupinder Thakur wrote:
+break;
+case VPL011_UARTRIS_OFFSET:
+*r = v->domain->arch.vpl011.raw_intr_status;
+break;
+case VPL011_UARTMIS_OFFSET:
+*r = v->domain->arch.vpl011.raw_intr_status &
+
Hi Julien,
+break;
+case VPL011_UARTDR_OFFSET:
+vpl011_read_data(v->domain, &ch);
>>>
>>>
>>>
>>> Should not you check the return value of vpl011_read_data? Also, what if
>>> there is no data?
>>
>> This condition should not happen because the RX FIF
.Hi Julien,
On 5 March 2017 at 17:42, Julien Grall wrote:
> Hi Bhupinder,
>
> On 21/02/17 11:25, Bhupinder Thakur wrote:
>>
>> diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c
>> new file mode 100644
>> index 000..88ba968
>> --- /dev/null
>> +++ b/xen/arch/arm/vpl011.c
>
>
> [...]
>
On 03/21/2017 01:27 PM, Bhupinder Thakur wrote:
Hi Julien,
Hi Bhupinder,
On 26 February 2017 at 22:37, Julien Grall wrote:
+break;
+case VPL011_UARTDR_OFFSET:
+vpl011_read_data(v->domain, &ch);
Should not you check the return value of vpl011_read_data? Als
Hi Konrad,
On 4 March 2017 at 01:29, Konrad Rzeszutek Wilk wrote:
> .snip..
>> +case VPL011_UARTCR_OFFSET:
>> +*r = v->domain->arch.vpl011.control;
>> +break;
>
> Pls add a new newline after each break.
Ok.
>
>> +case VPL011_UARTDR_OFFSET:
>> +
Hi Julien,
On 26 February 2017 at 22:37, Julien Grall wrote:
>> +
>> +#include
>
>
> xen/config.h is included by default. Please drop it.
Removed.
>
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>
>
> Why do you need to include monitor.h?
>
>> +#include
>>
On Sun, Mar 05, 2017 at 01:04:54AM +, Julien Grall wrote:
> Hi Konrad,
>
> On 03/03/2017 07:59 PM, Konrad Rzeszutek Wilk wrote:
> > > +}
> > > +
> > > +static int vpl011_data_avail(struct domain *d)
> > > +{
> > > +int rc=0;
> > > +unsigned long flags;
> > > +
> > > +struct console
Hi Bhupinder,
On 21/02/17 11:25, Bhupinder Thakur wrote:
diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c
new file mode 100644
index 000..88ba968
--- /dev/null
+++ b/xen/arch/arm/vpl011.c
[...]
+static int vpl011_mmio_write(struct vcpu *v, mmio_info_t *info, register_t r,
void
Hi Konrad,
On 03/03/2017 07:59 PM, Konrad Rzeszutek Wilk wrote:
+rc = alloc_unbound_xen_event_channel(d, 0, current->domain->domain_id,
+vpl011_notification);
+if (rc < 0)
Spaces.
+{
+printk ("Failed to allocate vpl01
Hi,
On 03/03/2017 07:59 PM, Konrad Rzeszutek Wilk wrote:
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index f2ecbc4..7e2feac 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -237,4 +237,10 @@ config FAST_SYMBOL_LOOKUP
The only user of this is Live patching.
Hi Konrad,
On 03/03/2017 07:59 PM, Konrad Rzeszutek Wilk wrote:
+}
+
+static int vpl011_data_avail(struct domain *d)
+{
+int rc=0;
+unsigned long flags;
+
+struct console_interface *intf=(struct console_interface
*)d->arch.vpl011.ring_buf;
Can you have an macro for this?
+
+V
.snip..
> +case VPL011_UARTCR_OFFSET:
> +*r = v->domain->arch.vpl011.control;
> +break;
Pls add a new newline after each break.
> +case VPL011_UARTDR_OFFSET:
> +vpl011_read_data(v->domain, &ch);
> +*r = ch;
> +break;
> +
Hi Bhupinder,
On 26/02/17 21:37, Julien Grall wrote:
On 02/21/2017 11:25 AM, Bhupinder Thakur wrote:
[...]
+{
+case VPL011_UARTCR_OFFSET:
Coding style: the case should be aligned to {. E.g
{
case ...
Also, I would prefer if you don't include _OFFSET in all the name.
Furtherm
Hi Bhupinder,
On 02/21/2017 11:25 AM, Bhupinder Thakur wrote:
Add emulation code to emulate read/write access to pl011 registers
and pl011 interrupts:
- It emulates DR read/write by reading and writing from/to the IN
and OUT ring buffers and raising an event to dom0 when there is
16 matches
Mail list logo
