Re: [Xen-devel] [PATCH] xentrace: simplify map_page function in xenctx

2016-03-19 Thread George Dunlap
On 03/03/16 13:10, Wei Liu wrote: > There were several problems: > > 1. Variable mapped was set to NULL so the following two "if"s were >useless. > 2. Variable previous_mfn was set but never used. mapped and previous_mfn are static, which (in this context) means they persists across invocatio

Re: [Xen-devel] [PATCH] xentrace: simplify map_page function in xenctx

2016-03-19 Thread Wei Liu
On Thu, Mar 17, 2016 at 11:48:39AM +, George Dunlap wrote: > On 03/03/16 13:10, Wei Liu wrote: > > There were several problems: > > > > 1. Variable mapped was set to NULL so the following two "if"s were > >useless. > > 2. Variable previous_mfn was set but never used. > > mapped and previo