Re: [Xen-devel] [PATCH] xen: use vMSI related #define-s from public interface

2017-09-21 Thread Stefano Stabellini
On Thu, 21 Sep 2017, Jan Beulich wrote: > >>> On 21.09.17 at 03:12, wrote: > > On Fri, 1 Sep 2017, Jan Beulich wrote: > >> --- a/hw/xen/xen_pt_msi.c > >> +++ b/hw/xen/xen_pt_msi.c > >> @@ -18,6 +18,11 @@ > >> > >> #define XEN_PT_AUTO_ASSIGN -1 > >> > >> +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MA

Re: [Xen-devel] [PATCH] xen: use vMSI related #define-s from public interface

2017-09-20 Thread Jan Beulich
>>> On 21.09.17 at 03:12, wrote: > On Fri, 1 Sep 2017, Jan Beulich wrote: >> --- a/hw/xen/xen_pt_msi.c >> +++ b/hw/xen/xen_pt_msi.c >> @@ -18,6 +18,11 @@ >> >> #define XEN_PT_AUTO_ASSIGN -1 >> >> +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MASK >> +#if XEN_DOMCTL_INTERFACE_VERSION >= 0x000e >> +

Re: [Xen-devel] [PATCH] xen: use vMSI related #define-s from public interface

2017-09-20 Thread Stefano Stabellini
On Fri, 1 Sep 2017, Jan Beulich wrote: > Xen and qemu having identical #define-s (with different names) is a > strong hint that these should have been part of the public interface > from the very start. Use them if they're available, falling back to > privately defined values only when using older

Re: [Xen-devel] [PATCH] xen: use vMSI related #define-s from public interface

2017-09-04 Thread Jan Beulich
>>> On 04.09.17 at 11:23, wrote: > On Mon, Sep 04, 2017 at 03:04:41AM -0600, Jan Beulich wrote: >> >>> On 01.09.17 at 20:20, wrote: >> > On Fri, Sep 01, 2017 at 10:25:42AM -0600, Jan Beulich wrote: >> >> Xen and qemu having identical #define-s (with different names) is a >> >> strong hint that th

Re: [Xen-devel] [PATCH] xen: use vMSI related #define-s from public interface

2017-09-04 Thread Roger Pau Monné
On Mon, Sep 04, 2017 at 03:04:41AM -0600, Jan Beulich wrote: > >>> On 01.09.17 at 20:20, wrote: > > On Fri, Sep 01, 2017 at 10:25:42AM -0600, Jan Beulich wrote: > >> Xen and qemu having identical #define-s (with different names) is a > >> strong hint that these should have been part of the public

Re: [Xen-devel] [PATCH] xen: use vMSI related #define-s from public interface

2017-09-04 Thread Jan Beulich
>>> On 01.09.17 at 20:20, wrote: > On Fri, Sep 01, 2017 at 10:25:42AM -0600, Jan Beulich wrote: >> Xen and qemu having identical #define-s (with different names) is a >> strong hint that these should have been part of the public interface >> from the very start. Use them if they're available, fall

Re: [Xen-devel] [PATCH] xen: use vMSI related #define-s from public interface

2017-09-01 Thread Roger Pau Monné
On Fri, Sep 01, 2017 at 10:25:42AM -0600, Jan Beulich wrote: > Xen and qemu having identical #define-s (with different names) is a > strong hint that these should have been part of the public interface > from the very start. Use them if they're available, falling back to > privately defined values