On Mon, Apr 04, 2016 at 08:07:13PM -0500, Chong Li wrote:
> Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
> a bug: it made it possible, in Credit and Credit2, when doing domain
> or vcpu parameters' manipulation, to leave the hypervisor with a
> spinlock held and interrupts
On Tue, 2016-04-05 at 10:25 +0100, George Dunlap wrote:
> On 05/04/16 08:57, Jan Beulich wrote:
> >
> > > Signed-off-by: Chong Li
> > >
> > > Acked-by: Dario Faggioli
> > This appears to be the 3rd variant of the patch, all with the same
> > bogus subject, and no versioning information at all.
On Tue, 2016-04-05 at 10:18 +0100, George Dunlap wrote:
> On 05/04/16 00:14, Andrew Cooper wrote:
> > On 04/04/2016 23:45, Chong Li wrote:
> > > ---
> > > xen/common/sched_credit.c | 1 +
> > > xen/common/sched_credit2.c | 1 +
> > > 2 files changed, 2 insertions(+)
> > >
> > > diff --git a/xen/
On 05/04/16 08:57, Jan Beulich wrote:
On 05.04.16 at 03:07, wrote:
>> Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
>> a bug: it made it possible, in Credit and Credit2, when doing domain
>> or vcpu parameters' manipulation, to leave the hypervisor with a
>> spinlock h
On 05/04/16 00:14, Andrew Cooper wrote:
> On 04/04/2016 23:45, Chong Li wrote:
>> From: Chong-Li
>>
>> Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
>> a bug: it made it possible, in Credit and Credit2, when doing domain
>> or vcpu parameters' manipulation, to leave the hy
>>> On 05.04.16 at 03:07, wrote:
> Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
> a bug: it made it possible, in Credit and Credit2, when doing domain
> or vcpu parameters' manipulation, to leave the hypervisor with a
> spinlock held and interrupts disabled.
>
> Fix it.
>
On Mon, Apr 4, 2016 at 9:07 PM, Chong Li wrote:
> Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
> a bug: it made it possible, in Credit and Credit2, when doing domain
> or vcpu parameters' manipulation, to leave the hypervisor with a
> spinlock held and interrupts disabled.
On 04/04/2016 23:45, Chong Li wrote:
> From: Chong-Li
>
> Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
> a bug: it made it possible, in Credit and Credit2, when doing domain
> or vcpu parameters' manipulation, to leave the hypervisor with a
> spinlock held.
And interrup
On Mon, 2016-04-04 at 16:21 -0500, Chong Li wrote:
> From: Chong-Li
>
> Fix a bug in sched_credit.c and sched_credit2.c: in the default case
> of csched_dom_cntl and csched2_dom_cntl, function returns without
> unlocking prv->lock.
>
This should mention what commit introduced the bug. Of course,
