Re: [Xen-devel] [PATCH] xen/x86: Fix errors arising from c/s dab76ff

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 16:15, wrote: > What about something like this instead? (Ported to be on top of this > patch, since it's already been committed.) > > -George > > [PATCH] xen/p2m: Make dump table printing less clever > > Rather than detecting whether to print out the numerical value of the

Re: [Xen-devel] [PATCH] xen/x86: Fix errors arising from c/s dab76ff

2016-02-15 Thread George Dunlap
On 12/02/16 14:59, Andrew Cooper wrote: > Coverity correctly identifies that the changes in mtrr_attrib_to_str() > introduce dead code. strings[] is a 2d array, rather than an array of > strings, which means that strings[x] will never be a NULL pointer. > > Adjust the check to compenstate, by loo

Re: [Xen-devel] [PATCH] xen/x86: Fix errors arising from c/s dab76ff

2016-02-12 Thread Andrew Cooper
On 12/02/16 15:13, Jan Beulich wrote: On 12.02.16 at 15:59, wrote: >> Coverity correctly identifies that the changes in mtrr_attrib_to_str() >> introduce dead code. strings[] is a 2d array, rather than an array of >> strings, which means that strings[x] will never be a NULL pointer. >> >> Ad

Re: [Xen-devel] [PATCH] xen/x86: Fix errors arising from c/s dab76ff

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 15:59, wrote: > Coverity correctly identifies that the changes in mtrr_attrib_to_str() > introduce dead code. strings[] is a 2d array, rather than an array of > strings, which means that strings[x] will never be a NULL pointer. > > Adjust the check to compenstate, by looking f