On Mon, 2016-01-04 at 16:28 +, Ian Jackson wrote:
> Alex Xu writes ("Re: [PATCH] xen/tools/get-fields.sh: Use printf for
> POSIX compat"):
> > Argh, claws mangled the formatting. Please ignore.
>
> Indeed. But, your code is good. When you repost please add my ack.
Jan already committed it.
Alex Xu writes ("[PATCH] xen/tools/get-fields.sh: Use printf for POSIX compat"):
> xen/tools/get-fields.sh used echo -n which is not POSIX compatible and
> breaks building with dash (shell). Change it to use printf "%s" which
> is usable everywhere.
Acked-by: Ian Jackson
Alex Xu writes ("Re: [PATCH] xen/tools/get-fields.sh: Use printf for POSIX
compat"):
> Argh, claws mangled the formatting. Please ignore.
Indeed. But, your code is good. When you repost please add my ack.
Ian.
___
Xen-devel mailing list
Xen-devel@li
>>> On 20.12.15 at 17:41, wrote:
> xen/tools/get-fields.sh used echo -n which is not POSIX compatible and
> breaks building with dash (shell). Change it to use printf '%s' which
> is usable everywhere.
>
> Signed-off-by: Alex Xu
My remarks on v1 regarding quotation still apply.
Jan
_
On Mon, 14 Dec 2015 13:22:28 -0500
Alex Xu wrote:
> xen/tools/get-fields.sh used echo -n which is not POSIX compatible and
> breaks building with dash (shell). Change it to use printf "%s" which
> is usable everywhere.
>
> Signed-off-by: Alex Xu
> ---
> xen/tools/get-fields.sh | 30 +++
>>> On 14.12.15 at 16:56, wrote:
> On Mon, 14 Dec 2015 02:12:16 -0700
> "Jan Beulich" wrote:
>
>> >>> On 12.12.15 at 19:18, wrote:
>> > xen/tools/get-fields.sh used echo -n which is not POSIX compatible
>> > and breaks with dash. Change it to use printf "%s" which is usable
>> > everywhere.
On Mon, 14 Dec 2015 02:12:16 -0700
"Jan Beulich" wrote:
> >>> On 12.12.15 at 19:18, wrote:
> > xen/tools/get-fields.sh used echo -n which is not POSIX compatible
> > and breaks with dash. Change it to use printf "%s" which is usable
> > everywhere.
>
> Looks okay, but a couple of remarks:
>
>>> On 12.12.15 at 19:18, wrote:
> xen/tools/get-fields.sh used echo -n which is not POSIX compatible and
> breaks with dash. Change it to use printf "%s" which is usable
> everywhere.
Looks okay, but a couple of remarks:
- For the unaware as well as to know why to take care going forward,
it w
