Re: [Xen-devel] [PATCH] x86: don't change affinity with interrupt unmasked

2015-03-26 Thread Jan Beulich
>>> On 25.03.15 at 19:12, wrote: >> Changing the affinity of non-maskable MSI IRQs seems bogus too > > Agreed. Their affinity can clearly only be changed safely by a device > driver which can guarantee that an interrupt will not be generated > during the vulnerable period. > > This further im

Re: [Xen-devel] [PATCH] x86: don't change affinity with interrupt unmasked

2015-03-25 Thread Andrew Cooper
On 20/03/15 16:40, Jan Beulich wrote: With ->startup unmasking the IRQ, setting the affinity afterwards without masking the IRQ again is invalid namely for MSI (which can't have their affinity updated atomically). Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- Changing the affini

Re: [Xen-devel] [PATCH] x86: don't change affinity with interrupt unmasked

2015-03-24 Thread Jan Beulich
>>> On 23.03.15 at 19:46, wrote: > On Fri, Mar 20, 2015 at 03:40:02PM +, Jan Beulich wrote: >> With ->startup unmasking the IRQ, setting the affinity afterwards >> without masking the IRQ again is invalid namely for MSI (which can't >> have their affinity updated atomically). > > That took a

Re: [Xen-devel] [PATCH] x86: don't change affinity with interrupt unmasked

2015-03-23 Thread Konrad Rzeszutek Wilk
On Fri, Mar 20, 2015 at 03:40:02PM +, Jan Beulich wrote: > With ->startup unmasking the IRQ, setting the affinity afterwards > without masking the IRQ again is invalid namely for MSI (which can't > have their affinity updated atomically). That took a bit of verification :-) Could you include