Re: [Xen-devel] [PATCH] x86/msi: Don't dereference pdev before its NULL check

2015-07-23 Thread Andrew Cooper
On 23/07/15 12:45, Jan Beulich wrote: On 23.07.15 at 12:54, wrote: >> --- a/xen/arch/x86/msi.c >> +++ b/xen/arch/x86/msi.c >> @@ -1345,7 +1345,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) >> struct msi_desc *entry, *tmp; >> struct irq_desc *desc; >> struct msi_msg msg;

Re: [Xen-devel] [PATCH] x86/msi: Don't dereference pdev before its NULL check

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 12:54, wrote: > --- a/xen/arch/x86/msi.c > +++ b/xen/arch/x86/msi.c > @@ -1345,7 +1345,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) > struct msi_desc *entry, *tmp; > struct irq_desc *desc; > struct msi_msg msg; > -u8 slot = PCI_SLOT(pdev->devfn), func