Re: [Xen-devel] [PATCH] x86/mm: drop pointless use of __FUNCTION__

2016-09-02 Thread George Dunlap
On Wed, Aug 24, 2016 at 9:01 AM, Jan Beulich wrote: > Non-debugging message text should be (and is here) distinguishable > without also logging function names. > > Signed-off-by: Jan Beulich Acked-by: George Dunlap > > --- a/xen/arch/x86/mm/paging.c > +++ b/xen/arch/x86/mm/paging.c > @@ -469,8

Re: [Xen-devel] [PATCH] x86/mm: drop pointless use of __FUNCTION__

2016-09-01 Thread Andrew Cooper
On 01/09/16 08:13, Jan Beulich wrote: On 31.08.16 at 20:39, wrote: >> On 24/08/16 09:01, Jan Beulich wrote: >>> Non-debugging message text should be (and is here) distinguishable >>> without also logging function names. >>> >>> Signed-off-by: Jan Beulich >>> >>> --- a/xen/arch/x86/mm/paging.

Re: [Xen-devel] [PATCH] x86/mm: drop pointless use of __FUNCTION__

2016-09-01 Thread Jan Beulich
>>> On 31.08.16 at 20:39, wrote: > On 24/08/16 09:01, Jan Beulich wrote: >> Non-debugging message text should be (and is here) distinguishable >> without also logging function names. >> >> Signed-off-by: Jan Beulich >> >> --- a/xen/arch/x86/mm/paging.c >> +++ b/xen/arch/x86/mm/paging.c >> @@ -469

Re: [Xen-devel] [PATCH] x86/mm: drop pointless use of __FUNCTION__

2016-08-31 Thread Andrew Cooper
On 24/08/16 09:01, Jan Beulich wrote: > Non-debugging message text should be (and is here) distinguishable > without also logging function names. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/mm/paging.c > +++ b/xen/arch/x86/mm/paging.c > @@ -469,8 +469,9 @@ static int paging_log_dirty_op(

Re: [Xen-devel] [PATCH] x86/mm: drop pointless use of __FUNCTION__

2016-08-24 Thread Konrad Rzeszutek Wilk
On Wed, Aug 24, 2016 at 02:01:09AM -0600, Jan Beulich wrote: > Non-debugging message text should be (and is here) distinguishable > without also logging function names. Reviewed-by: Konrad Rzeszutek Wilk > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/mm/paging.c > +++ b/xen/arch/x86/mm