Re: [Xen-devel] [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

2016-02-19 Thread Borislav Petkov
On Fri, Feb 19, 2016 at 01:21:10PM +0200, Andy Shevchenko wrote: > Heh, rebuilt on clean repository -> everything works. Looks like false > alarm and practical proof to do clean build first. Always, like *really* *always*, do $ make mrproper or even $ git clean -dqfx before testing kernels. I

Re: [Xen-devel] [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

2016-02-19 Thread Andy Shevchenko
On Fri, Feb 19, 2016 at 1:10 PM, Borislav Petkov wrote: > On Fri, Feb 19, 2016 at 01:00:35PM +0200, Andy Shevchenko wrote: >> That what I see last with earlycon enabled + `debug` in cmdline: > > That doesn't help. Heh, rebuilt on clean repository -> everything works. Looks like false alarm and pr

Re: [Xen-devel] [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

2016-02-19 Thread Borislav Petkov
On Fri, Feb 19, 2016 at 01:00:35PM +0200, Andy Shevchenko wrote: > That what I see last with earlycon enabled + `debug` in cmdline: That doesn't help. Can you dump RIP, etc registers as to where the machine freezes? Let me confirm this: booting with "dis_ucode_ldr" works? Also, please send .conf

Re: [Xen-devel] [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

2016-02-19 Thread Andy Shevchenko
On Fri, Feb 19, 2016 at 12:50 PM, Andy Shevchenko wrote: > On Fri, Feb 19, 2016 at 12:46 PM, Borislav Petkov wrote: >> On Fri, Feb 19, 2016 at 12:33:46PM +0200, Andy Shevchenko wrote: >>> commit 84aba677f009e20185aea322563389ad56e0ef7e >>> Author: Boris Ostrovsky >>> Date: Tue Feb 16 09:43:19

Re: [Xen-devel] [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

2016-02-19 Thread Andy Shevchenko
On Fri, Feb 19, 2016 at 12:46 PM, Borislav Petkov wrote: > On Fri, Feb 19, 2016 at 12:33:46PM +0200, Andy Shevchenko wrote: >> No, the commit 84aba677f009 as of today's linux-next on which I commented. > > You commented under the "> A subsequent commit, fbae4ba8c4a3" which confused > me > as to w

Re: [Xen-devel] [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

2016-02-19 Thread Borislav Petkov
On Fri, Feb 19, 2016 at 12:33:46PM +0200, Andy Shevchenko wrote: > No, the commit 84aba677f009 as of today's linux-next on which I commented. You commented under the "> A subsequent commit, fbae4ba8c4a3" which confused me as to which commit is the culprit. > commit 84aba677f009e20185aea322563389a

Re: [Xen-devel] [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

2016-02-19 Thread Andy Shevchenko
On Fri, Feb 19, 2016 at 12:18 PM, Borislav Petkov wrote: > On Fri, Feb 19, 2016 at 12:06:33PM +0200, Andy Shevchenko wrote: >> Sorry for being too late, but this commit breaks 32-bit kernel on >> Intel Medfield. Reverting the only commit from today's linux-next >> helps. > > You mean this commit?!

Re: [Xen-devel] [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

2016-02-19 Thread Borislav Petkov
On Fri, Feb 19, 2016 at 12:06:33PM +0200, Andy Shevchenko wrote: > Sorry for being too late, but this commit breaks 32-bit kernel on > Intel Medfield. Reverting the only commit from today's linux-next > helps. You mean this commit?! fbae4ba8c4a3 ("x86, microcode: Reload microcode on resume") Thi

Re: [Xen-devel] [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

2016-02-19 Thread Andy Shevchenko
On Thu, Feb 11, 2016 at 5:13 PM, Boris Ostrovsky wrote: > Commit a18a0f6850d4 ("x86, microcode: Don't initialize microcode code on > paravirt") added a paravirt test in microcode_init(), primarily to avoid > making mc_bp_resume()->load_ucode_ap()->check_loader_disabled_ap() calls > On 32-bit kerne

Re: [Xen-devel] [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

2016-02-11 Thread Borislav Petkov
On Thu, Feb 11, 2016 at 10:13:18AM -0500, Boris Ostrovsky wrote: > Commit a18a0f6850d4 ("x86, microcode: Don't initialize microcode code on > paravirt") added a paravirt test in microcode_init(), primarily to avoid > making mc_bp_resume()->load_ucode_ap()->check_loader_disabled_ap() calls > On 32-b