Re: [Xen-devel] [PATCH] tools/xenstore-watch: Add new timeout parameter

2016-03-19 Thread Razvan Cojocaru
On 03/16/2016 08:57 PM, Wei Liu wrote: > On Wed, Mar 16, 2016 at 08:52:57PM +0200, Razvan Cojocaru wrote: >> On 03/16/2016 08:46 PM, Wei Liu wrote: >>> On Wed, Mar 16, 2016 at 05:50:46PM +0200, Razvan Cojocaru wrote: >>> [...] } @@ -273,27 +274,49 @@ do_chmod(char *path, struct xs

Re: [Xen-devel] [PATCH] tools/xenstore-watch: Add new timeout parameter

2016-03-19 Thread Wei Liu
On Wed, Mar 16, 2016 at 08:52:57PM +0200, Razvan Cojocaru wrote: > On 03/16/2016 08:46 PM, Wei Liu wrote: > > On Wed, Mar 16, 2016 at 05:50:46PM +0200, Razvan Cojocaru wrote: > > [...] > >> } > >> > >> @@ -273,27 +274,49 @@ do_chmod(char *path, struct xs_permissions *perms, > >> int nperms, int

Re: [Xen-devel] [PATCH] tools/xenstore-watch: Add new timeout parameter

2016-03-19 Thread Andrew Cooper
On 16/03/16 17:43, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 16, 2016 at 05:50:46PM +0200, Razvan Cojocaru wrote: >> This patch allows xenstore-watch to exit even if no changes to its >> XenStore key have occured in a specified interval (in seconds), via >> a new -T parameter. > Should there be an

Re: [Xen-devel] [PATCH] tools/xenstore-watch: Add new timeout parameter

2016-03-19 Thread Konrad Rzeszutek Wilk
On Wed, Mar 16, 2016 at 05:50:46PM +0200, Razvan Cojocaru wrote: > This patch allows xenstore-watch to exit even if no changes to its > XenStore key have occured in a specified interval (in seconds), via > a new -T parameter. Should there be an update to the manpage as well? > > Signed-off-by: R

Re: [Xen-devel] [PATCH] tools/xenstore-watch: Add new timeout parameter

2016-03-19 Thread Wei Liu
On Wed, Mar 16, 2016 at 05:50:46PM +0200, Razvan Cojocaru wrote: [...] > } > > @@ -273,27 +274,49 @@ do_chmod(char *path, struct xs_permissions *perms, int > nperms, int upto, > } > > static void > -do_watch(struct xs_handle *xsh, int max_events) > +do_watch(struct xs_handle *xsh, int max_e

Re: [Xen-devel] [PATCH] tools/xenstore-watch: Add new timeout parameter

2016-03-18 Thread Razvan Cojocaru
On 03/16/2016 08:46 PM, Wei Liu wrote: > On Wed, Mar 16, 2016 at 05:50:46PM +0200, Razvan Cojocaru wrote: > [...] >> } >> >> @@ -273,27 +274,49 @@ do_chmod(char *path, struct xs_permissions *perms, int >> nperms, int upto, >> } >> >> static void >> -do_watch(struct xs_handle *xsh, int max_e