Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-30 Thread Wei Liu
On Fri, Sep 30, 2016 at 03:05:18AM -0600, Jan Beulich wrote: > >>> On 29.09.16 at 21:22, wrote: > > > > > On 29/09/2016 12:11, Julien Grall wrote: > >> Hi Jan, > >> > >> On 28/09/2016 23:04, Jan Beulich wrote: > >> On 28.09.16 at 21:42, wrote: > Hi Jan, > > On 28/09/2016 05:0

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-30 Thread Jan Beulich
>>> On 29.09.16 at 21:22, wrote: > > On 29/09/2016 12:11, Julien Grall wrote: >> Hi Jan, >> >> On 28/09/2016 23:04, Jan Beulich wrote: >> On 28.09.16 at 21:42, wrote: Hi Jan, On 28/09/2016 05:00, Jan Beulich wrote: > For consumers not using (fully) C99-aware compilers, li

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-29 Thread Wei Liu
On Thu, Sep 29, 2016 at 12:22:37PM -0700, Julien Grall wrote: > > > On 29/09/2016 12:11, Julien Grall wrote: > >Hi Jan, > > > >On 28/09/2016 23:04, Jan Beulich wrote: > >On 28.09.16 at 21:42, wrote: > >>>Hi Jan, > >>> > >>>On 28/09/2016 05:00, Jan Beulich wrote: > For consumers not using

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-29 Thread Julien Grall
On 29/09/2016 12:11, Julien Grall wrote: Hi Jan, On 28/09/2016 23:04, Jan Beulich wrote: On 28.09.16 at 21:42, wrote: Hi Jan, On 28/09/2016 05:00, Jan Beulich wrote: For consumers not using (fully) C99-aware compilers, limit the number of places where tweaking of the headers would be nece

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-29 Thread Julien Grall
Hi Jan, On 28/09/2016 05:00, Jan Beulich wrote: For consumers not using (fully) C99-aware compilers, limit the number of places where tweaking of the headers would be necessary: Introduce and use xen_mk_ullong(), allowing its helper macro to be overridden at once. For now don't touch public/io/

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-29 Thread Julien Grall
Hi Jan, On 28/09/2016 23:04, Jan Beulich wrote: On 28.09.16 at 21:42, wrote: Hi Jan, On 28/09/2016 05:00, Jan Beulich wrote: For consumers not using (fully) C99-aware compilers, limit the number of places where tweaking of the headers would be necessary: Introduce and use xen_mk_ullong(), al

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-29 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH] pub-headers: reduce C99 dependencies"): > I am not the author of the code, but I think it was to declare all the > constants of a given set uniformed. > > For instance all the GUEST_* constants are used to define the layout of > the guest. This may be shuffle in

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-28 Thread Jan Beulich
>>> On 28.09.16 at 21:42, wrote: > Hi Jan, > > On 28/09/2016 05:00, Jan Beulich wrote: >> For consumers not using (fully) C99-aware compilers, limit the number >> of places where tweaking of the headers would be necessary: Introduce >> and use xen_mk_ullong(), allowing its helper macro to be over

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-28 Thread Julien Grall
Hi Jan, On 28/09/2016 05:00, Jan Beulich wrote: For consumers not using (fully) C99-aware compilers, limit the number of places where tweaking of the headers would be necessary: Introduce and use xen_mk_ullong(), allowing its helper macro to be overridden at once. For now don't touch public/io/

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-28 Thread Jan Beulich
>>> On 28.09.16 at 16:04, wrote: > On Wed, Sep 28, 2016 at 06:00:31AM -0600, Jan Beulich wrote: >> For consumers not using (fully) C99-aware compilers, limit the number >> of places where tweaking of the headers would be necessary: Introduce >> and use xen_mk_ullong(), allowing its helper macro to

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-28 Thread Wei Liu
On Wed, Sep 28, 2016 at 08:14:51AM -0600, Jan Beulich wrote: > >>> On 28.09.16 at 16:04, wrote: > > On Wed, Sep 28, 2016 at 06:00:31AM -0600, Jan Beulich wrote: > >> For consumers not using (fully) C99-aware compilers, limit the number > >> of places where tweaking of the headers would be necessar

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-28 Thread Wei Liu
On Wed, Sep 28, 2016 at 06:00:31AM -0600, Jan Beulich wrote: > For consumers not using (fully) C99-aware compilers, limit the number > of places where tweaking of the headers would be necessary: Introduce > and use xen_mk_ullong(), allowing its helper macro to be overridden at > once. > > For now

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-28 Thread Jan Beulich
>>> On 28.09.16 at 15:31, wrote: > On 28/09/16 13:00, Jan Beulich wrote: >> For consumers not using (fully) C99-aware compilers, limit the number >> of places where tweaking of the headers would be necessary: Introduce >> and use xen_mk_ullong(), allowing its helper macro to be overridden at >> on

Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

2016-09-28 Thread George Dunlap
On 28/09/16 13:00, Jan Beulich wrote: > For consumers not using (fully) C99-aware compilers, limit the number > of places where tweaking of the headers would be necessary: Introduce > and use xen_mk_ullong(), allowing its helper macro to be overridden at > once. I'm just curious: Did you actually