Re: [Xen-devel] [PATCH] ocaml/xenctrl: Fix stub_xc_readconsolering()

2015-02-02 Thread Ian Campbell
On Fri, 2015-01-30 at 14:30 +, Dave Scott wrote: > > > > On 30 Jan 2015, at 14:11, Andrew Cooper wrote: > > > > The Ocaml stub to retrieve the hypervisor console ring had a few problems. > > > > * A single 32k buffer would truncate a large console ring. > > * The buffer was static and not

Re: [Xen-devel] [PATCH] ocaml/xenctrl: Fix stub_xc_readconsolering()

2015-01-30 Thread Dave Scott
> On 30 Jan 2015, at 14:11, Andrew Cooper wrote: > > The Ocaml stub to retrieve the hypervisor console ring had a few problems. > > * A single 32k buffer would truncate a large console ring. > * The buffer was static and not under the protection of the Ocaml GC lock so > could be clobbered b