Re: [Xen-devel] [PATCH] libxl: qmp: ensure qmp read buffer is NULL terminated

2016-03-01 Thread Ian Jackson
Ian Campbell writes ("[PATCH] libxl: qmp: ensure qmp read buffer is NULL terminated"): > Coverity rightly points out that qmp->buffer may not be NULL > terminated when passed to strncat. > > Make the actual buffer a byte bigger than QMP_RECEIVE_BUFFER_SIZE and > always append a NULL byte. > > I

Re: [Xen-devel] [PATCH] libxl: qmp: ensure qmp read buffer is NULL terminated

2016-02-23 Thread Ian Campbell
On Wed, 2016-02-17 at 11:02 +, Ian Campbell wrote: > Coverity rightly points out that qmp->buffer may not be NULL > terminated when passed to strncat. > > Make the actual buffer a byte bigger than QMP_RECEIVE_BUFFER_SIZE and > always append a NULL byte. > > I suspect that in practice we have