Re: [Xen-devel] [PATCH] libxl: adjust hvm direct boot code

2015-01-15 Thread Chun Yan Liu
>>> On 1/15/2015 at 10:51 PM, in message <20150115145156.ga3...@zion.uk.xensource.com>, Wei Liu wrote: > On Thu, Jan 15, 2015 at 01:50:27PM +, Ian Campbell wrote: > > On Thu, 2015-01-15 at 12:29 +, Wei Liu wrote: > > > The -initrd and -append parameters should only be supplied to QEMU

Re: [Xen-devel] [PATCH] libxl: adjust hvm direct boot code

2015-01-15 Thread Wei Liu
On Thu, Jan 15, 2015 at 01:50:27PM +, Ian Campbell wrote: > On Thu, 2015-01-15 at 12:29 +, Wei Liu wrote: > > The -initrd and -append parameters should only be supplied to QEMU iff > > -kernel parameter is present, because that's how QEMU works. > > What do you think of catching this e.g.

Re: [Xen-devel] [PATCH] libxl: adjust hvm direct boot code

2015-01-15 Thread Ian Campbell
On Thu, 2015-01-15 at 12:29 +, Wei Liu wrote: > The -initrd and -append parameters should only be supplied to QEMU iff > -kernel parameter is present, because that's how QEMU works. What do you think of catching this e.g. in the setdefault function and warning or erroring in this case? > Sign