Re: [Xen-devel] [PATCH] libelf: drop pointless uses of __FUNCTION__

2016-09-06 Thread Ian Jackson
Jan Beulich writes ("[PATCH] libelf: drop pointless uses of __FUNCTION__"): > Non-debugging message text should be (and is in the cases here, albeit > often only with the addition of an ELF: prefix) distinguishable without > also logging function names. > > In the messages touched at once use %#x

Re: [Xen-devel] [PATCH] libelf: drop pointless uses of __FUNCTION__

2016-09-06 Thread Andrew Cooper
On 06/09/16 16:10, Jan Beulich wrote: > --- a/xen/common/libelf/libelf-loader.c > +++ b/xen/common/libelf/libelf-loader.c > @@ -33,7 +33,7 @@ elf_errorstatus elf_init(struct elf_bina > > if ( !elf_is_elfbinary(image_input, size) ) > { > -elf_err(elf, "%s: not an ELF binary\n", _