Re: [Xen-devel] [PATCH] arm64/EFI: minor corrections

2015-01-12 Thread Jan Beulich
>>> On 12.01.15 at 14:46, wrote: > On Mon, 2015-01-12 at 08:59 +, Jan Beulich wrote: >> - don't bail when using the last slot of bootinfo.mem.bank[] (due to >> premature incrementing of the array index) >> - GUIDs should be static const (and placed into .init.* whenever >> possible) >> - P

Re: [Xen-devel] [PATCH] arm64/EFI: minor corrections

2015-01-12 Thread Ian Campbell
On Mon, 2015-01-12 at 08:59 +, Jan Beulich wrote: > - don't bail when using the last slot of bootinfo.mem.bank[] (due to > premature incrementing of the array index) > - GUIDs should be static const (and placed into .init.* whenever > possible) > - PrintErrMsg() issues a CR/LF pair itself -