Re: [Xen-devel] [PATCH] VMX: fix realmode emulation SReg handling

2016-10-28 Thread Jan Beulich
>>> On 28.10.16 at 17:29, wrote: > On 28/10/16 16:24, Jan Beulich wrote: >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -1499,18 +1499,18 @@ static void vmx_update_guest_cr(struct v >> /* Entering or leaving real mode: adjust the segment registers. >>

Re: [Xen-devel] [PATCH] VMX: fix realmode emulation SReg handling

2016-10-28 Thread Andrew Cooper
On 28/10/16 16:24, Jan Beulich wrote: > Commit 0888d36bb2 ("x86/emul: Correct the decoding of SReg3 operands") > overlooked three places where x86_seg_cs was assumed to be zero. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew CooperSorry for breaking this (especially as I had mentally note

Re: [Xen-devel] [PATCH] VMX: fix realmode emulation SReg handling

2016-10-28 Thread Wei Liu
On Fri, Oct 28, 2016 at 04:29:24PM +0100, Andrew Cooper wrote: > On 28/10/16 16:24, Jan Beulich wrote: > > Commit 0888d36bb2 ("x86/emul: Correct the decoding of SReg3 operands") > > overlooked three places where x86_seg_cs was assumed to be zero. > > > > Signed-off-by: Jan Beulich > > Reviewed-by