Re: [Xen-devel] [PATCH] VMX: fix/adjust trap injection

2015-11-24 Thread Andrew Cooper
On 23/11/15 15:24, Jan Beulich wrote: On 23.11.15 at 16:01, wrote: >> On 23/11/15 12:49, Jan Beulich wrote: >>> @@ -1525,6 +1516,16 @@ static void vmx_inject_trap(struct hvm_t >>> __restore_debug_registers(curr); >>> write_debugreg(6, read_debugreg(6) | DR_STEP); >>>

Re: [Xen-devel] [PATCH] VMX: fix/adjust trap injection

2015-11-23 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, November 23, 2015 8:49 PM > > In the course of investigating the 4.1.6 backport issue of the XSA-156 > patch I realized that #DB injection has always been broken, but with it > now getting always intercepted the problem has got worse:

Re: [Xen-devel] [PATCH] VMX: fix/adjust trap injection

2015-11-23 Thread Jan Beulich
>>> On 23.11.15 at 16:01, wrote: > On 23/11/15 12:49, Jan Beulich wrote: >> @@ -1525,6 +1516,16 @@ static void vmx_inject_trap(struct hvm_t >> __restore_debug_registers(curr); >> write_debugreg(6, read_debugreg(6) | DR_STEP); >> } >> +if ( !nestedhvm_vcpu

Re: [Xen-devel] [PATCH] VMX: fix/adjust trap injection

2015-11-23 Thread Andrew Cooper
On 23/11/15 12:49, Jan Beulich wrote: > In the course of investigating the 4.1.6 backport issue of the XSA-156 > patch I realized that #DB injection has always been broken, but with it > now getting always intercepted the problem has got worse: Documentation > clearly states that neither DR7.GD nor