Re: [Xen-devel] [PATCH] IOMMU: replace ASSERT()s checking for NULL

2016-11-07 Thread Konrad Rzeszutek Wilk
On Mon, Nov 07, 2016 at 10:30:37AM +, Andrew Cooper wrote: > On 07/11/16 09:24, Jan Beulich wrote: > > Avoid NULL derefs on non-debug builds. > > > > Coverity ID: 1055650 > > > > Signed-off-by: Jan Beulich > > Reviewed-by: Andrew Cooper This introduces a bug: > > > > > --- a/xen/drivers/pa

Re: [Xen-devel] [PATCH] IOMMU: replace ASSERT()s checking for NULL

2016-11-07 Thread Jan Beulich
>>> On 07.11.16 at 11:43, wrote: > On 07/11/16 09:53, Jan Beulich wrote: > On 07.11.16 at 10:24, wrote: >>> --- a/xen/drivers/passthrough/io.c >>> +++ b/xen/drivers/passthrough/io.c >>> @@ -165,7 +165,11 @@ static void pt_irq_time_out(void *data) >>> spin_lock(&irq_map->dom->event_lock);

Re: [Xen-devel] [PATCH] IOMMU: replace ASSERT()s checking for NULL

2016-11-07 Thread Andrew Cooper
On 07/11/16 09:53, Jan Beulich wrote: On 07.11.16 at 10:24, wrote: >> --- a/xen/drivers/passthrough/io.c >> +++ b/xen/drivers/passthrough/io.c >> @@ -165,7 +165,11 @@ static void pt_irq_time_out(void *data) >> spin_lock(&irq_map->dom->event_lock); >> >> dpci = domain_get_irq_dpci(

Re: [Xen-devel] [PATCH] IOMMU: replace ASSERT()s checking for NULL

2016-11-07 Thread Wei Liu
On Mon, Nov 07, 2016 at 10:30:37AM +, Andrew Cooper wrote: > On 07/11/16 09:24, Jan Beulich wrote: > > Avoid NULL derefs on non-debug builds. > > > > Coverity ID: 1055650 > > > > Signed-off-by: Jan Beulich > > Reviewed-by: Andrew Cooper > Release-acked-by: Wei Liu ___

Re: [Xen-devel] [PATCH] IOMMU: replace ASSERT()s checking for NULL

2016-11-07 Thread Andrew Cooper
On 07/11/16 09:24, Jan Beulich wrote: > Avoid NULL derefs on non-debug builds. > > Coverity ID: 1055650 > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper > > --- a/xen/drivers/passthrough/io.c > +++ b/xen/drivers/passthrough/io.c > @@ -165,7 +165,11 @@ static void pt_irq_time_out(void *

Re: [Xen-devel] [PATCH] IOMMU: replace ASSERT()s checking for NULL

2016-11-07 Thread Jan Beulich
>>> On 07.11.16 at 10:24, wrote: > --- a/xen/drivers/passthrough/io.c > +++ b/xen/drivers/passthrough/io.c > @@ -165,7 +165,11 @@ static void pt_irq_time_out(void *data) > spin_lock(&irq_map->dom->event_lock); > > dpci = domain_get_irq_dpci(irq_map->dom); > -ASSERT(dpci); > +if