Re: [Xen-devel] [[PATCH]] libxl/arm: Fix ARM build.

2017-05-16 Thread Wei Liu
On Tue, May 16, 2017 at 06:14:43PM +0300, Andrii Anisov wrote: > Dear Wei, > > > On 16.05.17 14:03, Wei Liu wrote: > > I'm confused by the commit message. > > My bad, I did not pay enough attention to write the message. Would following > be better? > > Implicitly initialize a referenced oup

Re: [Xen-devel] [[PATCH]] libxl/arm: Fix ARM build.

2017-05-16 Thread Andrii Anisov
Dear Wei, On 16.05.17 14:03, Wei Liu wrote: I'm confused by the commit message. My bad, I did not pay enough attention to write the message. Would following be better? Implicitly initialize a referenced ouput parameter for all code branches in order to not face a "variable may be

Re: [Xen-devel] [[PATCH]] libxl/arm: Fix ARM build.

2017-05-16 Thread Wei Liu
On Tue, May 16, 2017 at 12:03:49PM +0100, Wei Liu wrote: > On Tue, May 16, 2017 at 01:59:40PM +0300, Andrii Anisov wrote: > > CC Ian Jakson and Wei Liu as maintainers. > > > > Sincerely, > > Andrii Anisov. > > > > 2017-05-16 13:23 GMT+03:00 Andrii Anisov : > > > > > From: Andrii Anisov > > > >

Re: [Xen-devel] [[PATCH]] libxl/arm: Fix ARM build.

2017-05-16 Thread Wei Liu
On Tue, May 16, 2017 at 01:59:40PM +0300, Andrii Anisov wrote: > CC Ian Jakson and Wei Liu as maintainers. > > Sincerely, > Andrii Anisov. > > 2017-05-16 13:23 GMT+03:00 Andrii Anisov : > > > From: Andrii Anisov > > > > Some compilers do not (validly?) detect that size will always be > > initia

Re: [Xen-devel] [[PATCH]] libxl/arm: Fix ARM build.

2017-05-16 Thread Andrii Anisov
CC Ian Jakson and Wei Liu as maintainers. Sincerely, Andrii Anisov. 2017-05-16 13:23 GMT+03:00 Andrii Anisov : > From: Andrii Anisov > > Some compilers do not (validly?) detect that size will always be > initialized when (rc > 0), so implicitly initialize it. > > Signed-off-by: Julien Grall >