Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-08-02 Thread David Woodhouse
On Wed, 2017-08-02 at 03:17 -0600, Jan Beulich wrote: > > >... but then again, if the whole function is really doing nothing at > >all when invoked with delta==0 then perhaps it would just be easier to > >remove the first pass altogether. I feel sure I'm missing something, > > The reason is even

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-08-02 Thread Jan Beulich
>>> David Woodhouse 07/31/17 5:57 PM >>> >There is a first call to efi_arch_relocate_image(0) before the >ExitBootServices() call. However I'm missing something because I can't >see how that call achieves anything *other* than to trigger the fault >we're concerned about. > >There are three types o

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-31 Thread David Woodhouse
On Mon, 2017-07-31 at 07:15 -0600, Jan Beulich wrote: > > > > David Woodhouse 07/31/17 1:02 PM >>> > > On Sun, 2017-07-30 at 00:16 -0600, Jan Beulich wrote: > > > > > > David Woodhouse 07/20/17 5:22 PM >>> > > > > This includes stuff lke the hypercall tables which we really want > > > > to be rea

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-31 Thread Jan Beulich
>>> David Woodhouse 07/31/17 1:02 PM >>> >On Sun, 2017-07-30 at 00:16 -0600, Jan Beulich wrote: >> > > > David Woodhouse 07/20/17 5:22 PM >>> >> > This includes stuff lke the hypercall tables which we really want >> > to be read-only. And they were going into .data.read-mostly. >> Yes, we'd like

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-31 Thread David Woodhouse
On Sun, 2017-07-30 at 00:16 -0600, Jan Beulich wrote: > > > > > > > > > > > > > David Woodhouse 07/20/17 5:22 PM >>> > > This includes stuff lke the hypercall tables which we really want > > to be read-only. And they were going into .data.read-mostly. > Yes, we'd like them to be read-only, but

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-31 Thread David Woodhouse
On Mon, 2017-07-31 at 03:57 -0600, Jan Beulich wrote: > Are there any such relocations? The compiler shouldn't emit data needing > relocation to .rodata, so if at all such might live in assembly code. But yes, > if there are any, things would have been latently broken even before.  $ git diff 33a

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-31 Thread Jan Beulich
>>> David Woodhouse 07/31/17 1:19 AM >>> >On Sun, 2017-07-30 at 13:50 +0100, Andrew Cooper wrote: >> On 30/07/17 07:16, Jan Beulich wrote: >> > > > > David Woodhouse 07/20/17 5:22 PM >>> >> > > This includes stuff lke the hypercall tables which we really want >> > > to be read-only. And they were

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-31 Thread Jan Beulich
>>> Andrew Cooper 07/30/17 2:50 PM >>> >On 30/07/17 07:16, Jan Beulich wrote: > David Woodhouse 07/20/17 5:22 PM >>> >>> This includes stuff lke the hypercall tables which we really want >>> to be read-only. And they were going into .data.read-mostly. >> Yes, we'd like them to be read-only, b

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-30 Thread David Woodhouse
On Sun, 2017-07-30 at 13:50 +0100, Andrew Cooper wrote: > On 30/07/17 07:16, Jan Beulich wrote: > > > > > > > > > > > > > > > > > > > David Woodhouse 07/20/17 5:22 PM >>> > > > This includes stuff lke the hypercall tables which we really want > > > to be read-only. And they were going into .da

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-30 Thread Andrew Cooper
On 30/07/17 07:16, Jan Beulich wrote: David Woodhouse 07/20/17 5:22 PM >>> >> This includes stuff lke the hypercall tables which we really want >> to be read-only. And they were going into .data.read-mostly. > Yes, we'd like them to be read-only, but what if EFI properly assigned r/o > permis

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-29 Thread Jan Beulich
>>> David Woodhouse 07/20/17 5:22 PM >>> >This includes stuff lke the hypercall tables which we really want >to be read-only. And they were going into .data.read-mostly. Yes, we'd like them to be read-only, but what if EFI properly assigned r/o permissions to the .rodata section when loading xen.

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-21 Thread Andrew Cooper
On 21/07/17 11:43, Julien Grall wrote: On 20/07/17 17:54, Wei Liu wrote: On Thu, Jul 20, 2017 at 05:46:50PM +0100, Wei Liu wrote: CC relevant maintainers On Thu, Jul 20, 2017 at 05:20:43PM +0200, David Woodhouse wrote: From: David Woodhouse This includes stuff lke the hypercall tables whi

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-21 Thread Julien Grall
On 20/07/17 17:54, Wei Liu wrote: On Thu, Jul 20, 2017 at 05:46:50PM +0100, Wei Liu wrote: CC relevant maintainers On Thu, Jul 20, 2017 at 05:20:43PM +0200, David Woodhouse wrote: From: David Woodhouse This includes stuff lke the hypercall tables which we really want lke -> like to be

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-20 Thread Wei Liu
On Thu, Jul 20, 2017 at 05:46:50PM +0100, Wei Liu wrote: > CC relevant maintainers > > On Thu, Jul 20, 2017 at 05:20:43PM +0200, David Woodhouse wrote: > > From: David Woodhouse > > > > This includes stuff lke the hypercall tables which we really want lke -> like > > to be read-only. And they

Re: [Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-20 Thread Wei Liu
CC relevant maintainers On Thu, Jul 20, 2017 at 05:20:43PM +0200, David Woodhouse wrote: > From: David Woodhouse > > This includes stuff lke the hypercall tables which we really want > to be read-only. And they were going into .data.read-mostly. > > Signed-off-by: David Woodhouse > --- > Build

[Xen-devel] xen/link: Move .data.rel.ro sections into .rodata for final link

2017-07-20 Thread David Woodhouse
From: David Woodhouse This includes stuff lke the hypercall tables which we really want to be read-only. And they were going into .data.read-mostly. Signed-off-by: David Woodhouse --- Build tested on x86_64 (you really don't want to know about what I *actually* tested it with), not at all teste