Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-08-07 Thread James Morse
Hi Florian, On 03/08/17 17:00, Florian Jakobsmeier wrote: > regarding your previous mails. I was able to single step every instruction > of my module. The problem (or rather the solution) was to _disable_ the IRQ > interrupts from within my guest module. This solves the problem of > singlestepping

Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-08-03 Thread Florian Jakobsmeier
Hello James, Julien, regarding your previous mails. I was able to single step every instruction of my module. The problem (or rather the solution) was to _disable_ the IRQ interrupts from within my guest module. This solves the problem of singlestepping a module which previously ended in a spinloc

Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-08-03 Thread James Morse
Hi Florian, On 03/08/17 13:29, Florian Jakobsmeier wrote: > So as far as I understood both of you don't see a general problem with > (timer) interrupts or the scheduler while being single stepped? Because in > my opinion after enabling singlestep the system will go into a "spinlock" > routine. In

Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-08-03 Thread Florian Jakobsmeier
> Sets TDE to trap debug exceptions to EL2 from lower exception levels. I'm >> surprised this isn't always set for Xen. Do you allow guests to use the >> debug >> features for their own purposes? >> > > No. We already trap debug exceptions to EL2 by default and MDCR_EL2 should > already be configur

Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-08-03 Thread Julien Grall
On 03/08/17 11:46, James Morse wrote: Hi Florian, On 03/08/17 11:16, Florian Jakobsmeier wrote: This is the current version: I'm not familiar with Xen, so forgive my annotations: asmlinkage void leave_hypervisor_tail(void) { +/*This methode will be called after the 'guest_entry' mac

Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-08-03 Thread James Morse
Hi Florian, On 03/08/17 11:16, Florian Jakobsmeier wrote: > This is the current version: I'm not familiar with Xen, so forgive my annotations: > asmlinkage void leave_hypervisor_tail(void) >> { >> +/*This methode will be called after the 'guest_entry' macro in >> /arch/arm64/entry.S set gue

Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-08-03 Thread Florian Jakobsmeier
Hey Julien, Would you mind sharing the latest version of your code? > > Of course not. This is the current version: asmlinkage void leave_hypervisor_tail(void) > { > +/*This methode will be called after the 'guest_entry' macro in > /arch/arm64/entry.S set guest registers > +Check single

Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-08-03 Thread James Morse
Hi Florian, Julien, On 02/08/17 14:32, Julien Grall wrote: > On 26/07/17 14:12, Florian Jakobsmeier wrote: >> i was just testing the single step implementation and realized that the >> before mentioned solution is not fully working. I'm still trying to >> enable SS for a VM on Xen. >> To test my

Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-08-02 Thread Julien Grall
Hi Florian, Sorry for the late answer. On 26/07/17 14:12, Florian Jakobsmeier wrote: Hello, i was just testing the single step implementation and realized that the before mentioned solution is not fully working. I'm still trying to enable SS for a VM on Xen. Would you mind sharing the latest

Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-07-26 Thread Florian Jakobsmeier
Hello, i was just testing the single step implementation and realized that the before mentioned solution is not fully working. I'm still trying to enable SS for a VM on Xen. To test my implementation i wrote a small Kernel Module and started it in the DomU. The module only contains a loop which in

Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-07-05 Thread Florian Jakobsmeier
2017-07-04 20:37 GMT+02:00 Julien Grall : > > On 07/04/2017 01:30 PM, Florian Jakobsmeier wrote: > >> Hello all, >> > > Hi Florian, > > > asmlinkage void leave_hypervisor_tail(void) >> { >> +/*This methode will be called after the 'guest_entry' macro in >> /arch/arm64/entry

Re: [Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-07-04 Thread Julien Grall
On 07/04/2017 01:30 PM, Florian Jakobsmeier wrote: Hello all, Hi Florian, asmlinkage void leave_hypervisor_tail(void) { +/*This methode will be called after the 'guest_entry' macro in /arch/arm64/entry.S set guest registers +Check single_step_enabled flag in d

[Xen-devel] xen/arm: Software Step ARMv8 - PC stuck on instruction

2017-07-04 Thread Florian Jakobsmeier
Hello all, I'm trying to implement a single step functionality for XEN on ARMv8 using "Software Step Exceptions". My problem with this is, that after taking the exception the PC will stay on the same instruction. By adding a "singlestep_enabled" flag in the "struct arch_domain" (based on the sing