Re: [Xen-devel] race in vif-common.sh

2017-07-27 Thread George Dunlap
> On Jul 27, 2017, at 6:11 PM, Andreas Kinzler wrote: > > On Thu, 27 Jul 2017 18:49:47 +0200, George Dunlap > wrote: >>> Sorry, I think that this patch is just far to complicated. If you really >>> want to keep the "iptables is working check" (lines 1-7 of function >>> handle_iptable) then y

Re: [Xen-devel] race in vif-common.sh

2017-07-27 Thread Andreas Kinzler
On Thu, 27 Jul 2017 18:49:47 +0200, George Dunlap wrote: Sorry, I think that this patch is just far to complicated. If you really want to keep the "iptables is working check" (lines 1-7 of function handle_iptable) then you should just move it inside the claim_lock "iptables" section and yo

Re: [Xen-devel] race in vif-common.sh

2017-07-27 Thread George Dunlap
> On Jul 27, 2017, at 5:12 PM, Andreas Kinzler wrote: > > On Thu, 27 Jul 2017 12:55:14 +0200, George Dunlap > wrote: >> For 4.9 we checked in a fix to this problem that would specifically >> attempt to use the -w option if it was available; see c/s 3d2010f9ff. > > Sorry, I think that this pat

Re: [Xen-devel] race in vif-common.sh

2017-07-27 Thread Andreas Kinzler
On Thu, 27 Jul 2017 12:55:14 +0200, George Dunlap wrote: For 4.9 we checked in a fix to this problem that would specifically attempt to use the -w option if it was available; see c/s 3d2010f9ff. Sorry, I think that this patch is just far to complicated. If you really want to keep the "iptab

Re: [Xen-devel] race in vif-common.sh

2017-07-27 Thread George Dunlap
On 07/03/2017 02:07 PM, Wei Liu wrote: > CC George (author of recent change) and Ian > > On Mon, Jul 03, 2017 at 01:30:09PM +0200, Andreas Kinzler wrote: >> Hello >> >> in /etc/xen/scripts/vif-common.sh there is a function handle_iptable. >> At its start there is a check for a working iptables imp

Re: [Xen-devel] race in vif-common.sh

2017-07-03 Thread Wei Liu
CC George (author of recent change) and Ian On Mon, Jul 03, 2017 at 01:30:09PM +0200, Andreas Kinzler wrote: > Hello > > in /etc/xen/scripts/vif-common.sh there is a function handle_iptable. > At its start there is a check for a working iptables implementation. > This check is outside the iptable

[Xen-devel] race in vif-common.sh

2017-07-03 Thread Andreas Kinzler
Hello in /etc/xen/scripts/vif-common.sh there is a function handle_iptable. At its start there is a check for a working iptables implementation. This check is outside the iptables lock section (claim_lock "iptables") and even if it is only a read-only operation the underlying iptables operatio

[Xen-devel] race in vif-common.sh

2017-07-03 Thread Andreas Kinzler
Hello in /etc/xen/scripts/vif-common.sh there is a function handle_iptable. At its start there is a check for a working iptables implementation. This check is outside the iptables lock section (claim_lock "iptables") and even if it is only a read-only operation the underlying iptables operatio