Re: [Xen-devel] potential problem with qdisk backend

2016-05-16 Thread Stefano Stabellini
On Wed, 11 May 2016, Juergen Gross wrote: > On 06/05/16 13:41, Juergen Gross wrote: > > Looking at the qdisk backend implementation I wondered whether > > blkif_get_x86_32_req() is really correct, especially for the > > BLKIF_OP_DISCARD case. The Linux kernel based blk backend seems to > > distingu

Re: [Xen-devel] potential problem with qdisk backend

2016-05-13 Thread Jan Beulich
>>> On 06.05.16 at 13:41, wrote: > Looking at the qdisk backend implementation I wondered whether > blkif_get_x86_32_req() is really correct, especially for the > BLKIF_OP_DISCARD case. The Linux kernel based blk backend seems to > distinguish 32- and 64-bit layouts of blkif_request_discard while

Re: [Xen-devel] potential problem with qdisk backend

2016-05-11 Thread Juergen Gross
On 06/05/16 13:41, Juergen Gross wrote: > Looking at the qdisk backend implementation I wondered whether > blkif_get_x86_32_req() is really correct, especially for the > BLKIF_OP_DISCARD case. The Linux kernel based blk backend seems to > distinguish 32- and 64-bit layouts of blkif_request_discard

[Xen-devel] potential problem with qdisk backend

2016-05-06 Thread Juergen Gross
Looking at the qdisk backend implementation I wondered whether blkif_get_x86_32_req() is really correct, especially for the BLKIF_OP_DISCARD case. The Linux kernel based blk backend seems to distinguish 32- and 64-bit layouts of blkif_request_discard while qemu treats them to be the same. Am I com