Re: [Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-24 Thread Olaf Hering
On Fri, Mar 20, Ian Campbell wrote: > On Fri, 2015-03-20 at 17:44 +0100, Olaf Hering wrote: > > + ("dev", Struct(None, [("m", libxl_vscsi_hctl)])), > > + ("wwn", Struct(None, [("m", string)])), > > + ("hctl", Struct(None, [("m", libxl_vscsi_hctl)])), > > > > Aside: What is

Re: [Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 17:44 +0100, Olaf Hering wrote: > + ("dev", Struct(None, [("m", libxl_vscsi_hctl)])), > + ("wwn", Struct(None, [("m", string)])), > + ("hctl", Struct(None, [("m", libxl_vscsi_hctl)])), > > Aside: What is the difference between dev and hctl in this cont

Re: [Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-20 Thread Olaf Hering
On Fri, Mar 20, Ian Campbell wrote: > The name at (*) must be the enum member, which I've duplicated at (**) > but you might like to thing about whether (**) would have a better name > in the context of e.g. vscsi_dev->u.dev.dev or vscsi_dev->u.wwn.wwn. Thanks Ian. For some reason I have ocaml di

Re: [Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 09:10 +0100, Olaf Hering wrote: > Some change commited to staging earlier this week breaks ocaml bindings, > as shown below. I think it was introduced between > a68d1b65bb1bbb9b8db2d82695d32ac09c52a2d7..d4ea77c9d7b314001ff4e2eb7618b45f11551371: > > NotImplementedError: Cannot

[Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-20 Thread Olaf Hering
Some change commited to staging earlier this week breaks ocaml bindings, as shown below. I think it was introduced between a68d1b65bb1bbb9b8db2d82695d32ac09c52a2d7..d4ea77c9d7b314001ff4e2eb7618b45f11551371: NotImplementedError: Cannot handle KeyedUnion fields which are not Structs But now that I