Re: [Xen-devel] Questions about the use of idle_vcpu[]

2016-01-19 Thread Tianyang Chen
On 1/18/2016 11:07 AM, Meng Xu wrote: On Mon, Jan 18, 2016 at 6:00 AM, Dario Faggioli wrote: On Mon, 2016-01-18 at 10:47 +, George Dunlap wrote: On Fri, Jan 15, 2016 at 1:04 AM, Tianyang Chen If an idle vcpu is picked, the ret.time is set accordingly in both credit and credit2 by che

Re: [Xen-devel] Questions about the use of idle_vcpu[]

2016-01-18 Thread Meng Xu
Hi Dario, On Mon, Jan 18, 2016 at 11:32 AM, Dario Faggioli wrote: > On Mon, 2016-01-18 at 11:07 -0500, Meng Xu wrote: >> On Mon, Jan 18, 2016 at 6:00 AM, Dario Faggioli >> wrote: >> > >> > RTDS behavior is broken in many respect, including this, >> > >> > and in fact, >> > Meng and Tianyang are

Re: [Xen-devel] Questions about the use of idle_vcpu[]

2016-01-18 Thread Dario Faggioli
On Mon, 2016-01-18 at 11:07 -0500, Meng Xu wrote: > On Mon, Jan 18, 2016 at 6:00 AM, Dario Faggioli > wrote: > >  > > RTDS behavior is broken in many respect, including this, > > > > and in fact, > > Meng and Tianyang are sending patches already to fix it (I'll let > > you > > guys have my commen

Re: [Xen-devel] Questions about the use of idle_vcpu[]

2016-01-18 Thread Meng Xu
On Mon, Jan 18, 2016 at 6:00 AM, Dario Faggioli wrote: > > On Mon, 2016-01-18 at 10:47 +, George Dunlap wrote: > > On Fri, Jan 15, 2016 at 1:04 AM, Tianyang Chen > > > > > If an idle vcpu is picked, the ret.time is set accordingly in both > > > credit > > > and credit2 by checking whether sne

Re: [Xen-devel] Questions about the use of idle_vcpu[]

2016-01-18 Thread Dario Faggioli
On Mon, 2016-01-18 at 12:37 +, George Dunlap wrote: > On Mon, Jan 18, 2016 at 11:00 AM, Dario Faggioli > wrote: > > >  > > Credit2, AFAICR, could also avoid _always_ re-setting the timer, > > but it > > does need to do that at least a few times, even when idle is > > selected, > > because of t

Re: [Xen-devel] Questions about the use of idle_vcpu[]

2016-01-18 Thread George Dunlap
On Mon, Jan 18, 2016 at 11:00 AM, Dario Faggioli wrote: >> It looks like credit2's behavior will probably prevent the processor >> from going into deeper power-saving states, and rtds' behavior might >> cause it to essentially busy-wait. >> > RTDS behavior is broken in many respect, including this

Re: [Xen-devel] Questions about the use of idle_vcpu[]

2016-01-18 Thread Dario Faggioli
On Mon, 2016-01-18 at 10:47 +, George Dunlap wrote: > On Fri, Jan 15, 2016 at 1:04 AM, Tianyang Chen > > > If an idle vcpu is picked, the ret.time is set accordingly in both > > credit > > and credit2 by checking whether snext is idle. if so, credit > > returns -1 and > > credit2 returns 2ms.

Re: [Xen-devel] Questions about the use of idle_vcpu[]

2016-01-18 Thread George Dunlap
On Fri, Jan 15, 2016 at 1:04 AM, Tianyang Chen wrote: > Hello, > > I'm confused by the use of idle_vcpu[] in Xen schedulers. In credit, credit2 > and rtds schedulers, they are used in conjunction with variable > "tasklet_work_scheduled" like this: > > if ( tasklet_work_scheduled ) > { > snext

[Xen-devel] Questions about the use of idle_vcpu[]

2016-01-14 Thread Tianyang Chen
Hello, I'm confused by the use of idle_vcpu[] in Xen schedulers. In credit, credit2 and rtds schedulers, they are used in conjunction with variable "tasklet_work_scheduled" like this: if ( tasklet_work_scheduled ) { snext = #_VCPU(idle_vcpu[cpu]); } The idle_vcpu array is initia