Re: [Xen-devel] QEMU commit 04bf2526ce breaks use of xen-mapcache

2017-07-25 Thread Paolo Bonzini
> > Thanks---however, after re-reading xen-mapcache.c, dma needs to be false > > for unlocked mappings. > > If there is a DMA operation already in progress, it means that we'll > already have a locked mapping for it. Yes, I only wanted to say that qemu_ram_ptr_length should pass dma=false when c

Re: [Xen-devel] QEMU commit 04bf2526ce breaks use of xen-mapcache

2017-07-25 Thread Stefano Stabellini
On Tue, 25 Jul 2017, Paolo Bonzini wrote: > - Original Message - > > From: "Stefano Stabellini" > > To: "Paolo Bonzini" > > Cc: "Anthony PERARD" , "Stefano Stabellini" > > , > > xen-devel@lists.xen.org, qemu-de...@nongnu.org > > Sent: Tuesday, July 25, 2017 8:08:21 PM > > Subject: Re: QE

Re: [Xen-devel] QEMU commit 04bf2526ce breaks use of xen-mapcache

2017-07-25 Thread Paolo Bonzini
- Original Message - > From: "Stefano Stabellini" > To: "Paolo Bonzini" > Cc: "Anthony PERARD" , "Stefano Stabellini" > , > xen-devel@lists.xen.org, qemu-de...@nongnu.org > Sent: Tuesday, July 25, 2017 8:08:21 PM > Subject: Re: QEMU commit 04bf2526ce breaks use of xen-mapcache > > On

Re: [Xen-devel] QEMU commit 04bf2526ce breaks use of xen-mapcache

2017-07-25 Thread Stefano Stabellini
On Tue, 25 Jul 2017, Paolo Bonzini wrote: > > Hi, > > > > Commits 04bf2526ce (exec: use qemu_ram_ptr_length to access guest ram) > > start using qemu_ram_ptr_length() instead of qemu_map_ram_ptr(). > > That result in calling xen_map_cache() with lock=true, but this mapping > > is never invalidated

Re: [Xen-devel] QEMU commit 04bf2526ce breaks use of xen-mapcache

2017-07-25 Thread Paolo Bonzini
> Hi, > > Commits 04bf2526ce (exec: use qemu_ram_ptr_length to access guest ram) > start using qemu_ram_ptr_length() instead of qemu_map_ram_ptr(). > That result in calling xen_map_cache() with lock=true, but this mapping > is never invalidated. > So QEMU use more and more RAM until it stop workin

[Xen-devel] QEMU commit 04bf2526ce breaks use of xen-mapcache

2017-07-25 Thread Anthony PERARD
Hi, Commits 04bf2526ce (exec: use qemu_ram_ptr_length to access guest ram) start using qemu_ram_ptr_length() instead of qemu_map_ram_ptr(). That result in calling xen_map_cache() with lock=true, but this mapping is never invalidated. So QEMU use more and more RAM until it stop working for a reason