Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-04 Thread Wei Liu
On Wed, May 04, 2016 at 04:13:48PM +0200, Olaf Hering wrote: > On Wed, May 04, Wei Liu wrote: > > > Are these gnutls.git commits? > > Its from qemu.git, after all its a bug in qemu. > Oh, right. That makes sense! In that case I can just use those commits. This is very useful information. Thank

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-04 Thread Olaf Hering
On Wed, May 04, Wei Liu wrote: > Are these gnutls.git commits? Its from qemu.git, after all its a bug in qemu. Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-04 Thread Wei Liu
On Wed, May 04, 2016 at 04:03:57PM +0200, Olaf Hering wrote: > On Wed, May 04, Wei Liu wrote: > > > I will go check the gnutls repo and update this patch accordingly. In > > the meantime I will wait for comment on the priority list. If you know > > any documents please let me know. > > I cant hel

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-04 Thread Olaf Hering
On Wed, May 04, Wei Liu wrote: > I will go check the gnutls repo and update this patch accordingly. In > the meantime I will wait for comment on the priority list. If you know > any documents please let me know. I cant help with that. My xen.rpm carries upstream commits f40d55081667a716312b9a8b6

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-04 Thread Wei Liu
On Wed, May 04, 2016 at 03:38:01PM +0200, Olaf Hering wrote: > On Wed, May 04, Wei Liu wrote: > > > Do you have a link to the NEWS file so that I can read and put it into > > the commit message? https://www.gnutls.org/news.html doesn't seem to > > cover release that old. > > I cloned their git t

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-04 Thread Olaf Hering
On Wed, May 04, Wei Liu wrote: > Do you have a link to the NEWS file so that I can read and put it into > the commit message? https://www.gnutls.org/news.html doesn't seem to > cover release that old. I cloned their git tree. git clone https://gitlab.com/gnutls/gnutls.git Thanks anyway for mak

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-04 Thread Wei Liu
On Wed, May 04, 2016 at 03:06:04PM +0200, Olaf Hering wrote: > On Wed, May 04, Wei Liu wrote: > > > gnutls_kx_set_priority, gnutls_certificate_type_set_priority and > > gnutls_protocol_set_priority are removed in 3.4. Application should use > > gnutls_priority_set_direct instead. > > > +#if defin

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-04 Thread Olaf Hering
On Wed, May 04, Wei Liu wrote: > gnutls_kx_set_priority, gnutls_certificate_type_set_priority and > gnutls_protocol_set_priority are removed in 3.4. Application should use > gnutls_priority_set_direct instead. > +#if defined(GNUTLS_VERSION_NUMBER) && \ > +GNUTLS_VERSION_NUMBER >= 0x030400 /*

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-04 Thread Wei Liu
On Tue, May 03, 2016 at 12:49:07PM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, May 03, 2016 at 05:35:45PM +0100, Wei Liu wrote: > > The original patch seems to malformed. > > > > I skim the code, the refactoring parts look correct to me. What I'm not > > sure is whether the replacement is correc

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-03 Thread Wei Liu
On Tue, May 03, 2016 at 12:49:07PM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, May 03, 2016 at 05:35:45PM +0100, Wei Liu wrote: > > The original patch seems to malformed. > > > > I skim the code, the refactoring parts look correct to me. What I'm not > > sure is whether the replacement is correc

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-03 Thread Konrad Rzeszutek Wilk
On Tue, May 03, 2016 at 05:35:45PM +0100, Wei Liu wrote: > The original patch seems to malformed. > > I skim the code, the refactoring parts look correct to me. What I'm not > sure is whether the replacement is correct or not. > > The reference to gnutls_priority_set_direct in [0] is from a secti

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-03 Thread Wei Liu
The original patch seems to malformed. I skim the code, the refactoring parts look correct to me. What I'm not sure is whether the replacement is correct or not. The reference to gnutls_priority_set_direct in [0] is from a section called "Upgrading to 3.4.x from 3.3.x", while the version check in

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-05-03 Thread Konrad Rzeszutek Wilk
On Fri, Apr 01, 2016 at 12:45:26PM -0400, Konrad Rzeszutek Wilk wrote: Hey Wei, Ian, We really need this for Xen 4.7 - otherwise you cannot build qemu-trad under Fedora Core 23: home/konrad/ssd/konrad/xen/tools/qemu-xen-traditional-dir/hw/usb-net.c: In function ‘usbnet_receive’: /home/konrad/ss

Re: [Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-04-01 Thread Konrad Rzeszutek Wilk
On Fri, Apr 01, 2016 at 06:31:00PM +0200, Sjoer van der Ploeg wrote: > Dear Konrad, > > > The patch was tested on my testbed, after discovering that the build > failed. I had no need for qemu-traditional and forgot to disable it, but I > hate build errors ;) > > I do not think there should be a

[Xen-devel] QEMU-TRAD Re: [PATCH] Fixed building with newer GNUTLS versions.

2016-04-01 Thread Konrad Rzeszutek Wilk
On Thu, Mar 31, 2016 at 10:58:19PM +0200, Sjoer van der Ploeg wrote: Heya! Thank you for posting this and also adding the #ifdef for older versions! Was wondering thought - had you double-checked that the new code path works with the certs? Thanks! P.S. CC-ing Ian who is the QEMU-traditional m