Re: [Xen-devel] BUG in xennet_make_frags with paged skb data

2014-11-10 Thread Frediano Ziglio
2014-11-10 16:42 GMT+00:00 David Vrabel : > On 10/11/14 16:39, Zoltan Kiss wrote: > > > > The BUG_ON suggested by Stefan would be still reasonable: > > > > BUG_ON(((page-compound_head(page))*PAGE_SIZE)+offset+len > > > PAGE_SIZE< > Well, it wouldn't trigger but I don't think it is useful any more.

Re: [Xen-devel] BUG in xennet_make_frags with paged skb data

2014-11-10 Thread Eric Dumazet
On Mon, 2014-11-10 at 16:42 +, David Vrabel wrote: > On 10/11/14 16:39, Zoltan Kiss wrote: > > > > The BUG_ON suggested by Stefan would be still reasonable: > > > > BUG_ON(((page-compound_head(page))*PAGE_SIZE)+offset+len > > > PAGE_SIZE< > Well, it wouldn't trigger but I don't think it is u

Re: [Xen-devel] BUG in xennet_make_frags with paged skb data

2014-11-10 Thread Zoltan Kiss
On 10/11/14 14:41, David Vrabel wrote: On 10/11/14 14:35, Seth Forshee wrote: On Fri, Nov 07, 2014 at 10:44:15AM +, David Vrabel wrote: On 06/11/14 21:49, Seth Forshee wrote: We've had several reports of hitting the following BUG_ON in xennet_make_frags with 3.2 and 3.13 kernels (I'm cur

Re: [Xen-devel] BUG in xennet_make_frags with paged skb data

2014-11-10 Thread David Vrabel
On 10/11/14 16:39, Zoltan Kiss wrote: > > The BUG_ON suggested by Stefan would be still reasonable: > > BUG_ON(((page-compound_head(page))*PAGE_SIZE)+offset+len > > PAGE_SIZE

Re: [Xen-devel] BUG in xennet_make_frags with paged skb data

2014-11-10 Thread David Vrabel
On 10/11/14 14:35, Seth Forshee wrote: > On Fri, Nov 07, 2014 at 10:44:15AM +, David Vrabel wrote: >> On 06/11/14 21:49, Seth Forshee wrote: >>> We've had several reports of hitting the following BUG_ON in >>> xennet_make_frags with 3.2 and 3.13 kernels (I'm currently awaiting >>> results of te

Re: [Xen-devel] BUG in xennet_make_frags with paged skb data

2014-11-10 Thread Seth Forshee
On Fri, Nov 07, 2014 at 10:44:15AM +, David Vrabel wrote: > On 06/11/14 21:49, Seth Forshee wrote: > > We've had several reports of hitting the following BUG_ON in > > xennet_make_frags with 3.2 and 3.13 kernels (I'm currently awaiting > > results of testing with 3.17): > > > > /* Gran