Re: [Xen-devel] [v10][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-20 Thread Jan Beulich
>>> On 20.07.15 at 16:35, wrote: > Looks just a little bit should be changed so I also paste this new > online to try winning your Acked here, Just like the other one, provided it also works, Reviewed-by: Jan Beulich ___ Xen-devel mailing list Xen-d

Re: [Xen-devel] [v10][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-20 Thread Chen, Tiejun
Looks just a little bit should be changed so I also paste this new online to try winning your Acked here, hvmloader/e820: construct guest e820 table Now use the hypervisor-supplied memory map to build our final e820 table: * Add regions for BIOS ranges and other special mappings not in the h

Re: [Xen-devel] [v10][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-20 Thread Chen, Tiejun
Actually, now that you mention it -- this should probably happen instead when we update hvm_info->{low,high}_mem_pgend. I also considered this point previously but I thought just right now we only update hvm_info->low/high_mem_pgend inside pci_setup(). But you can't guarantee this would be a so

Re: [Xen-devel] [v10][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-20 Thread George Dunlap
On Mon, Jul 20, 2015 at 2:23 PM, Chen, Tiejun wrote: >>> v10: >>> >>> * Instead of correcting e820, I'd like to correct memory_map.map[] >>>and then copy them into e820 directly. I think this can make sure >>>hvm_info, memory_map.map[] and e820 are on the same page. >> >> >> Actually, now

Re: [Xen-devel] [v10][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-20 Thread Chen, Tiejun
v10: * Instead of correcting e820, I'd like to correct memory_map.map[] and then copy them into e820 directly. I think this can make sure hvm_info, memory_map.map[] and e820 are on the same page. Actually, now that you mention it -- this should probably happen instead when we update hvm_i

Re: [Xen-devel] [v10][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-20 Thread George Dunlap
On Mon, Jul 20, 2015 at 7:16 AM, Tiejun Chen wrote: > Now use the hypervisor-supplied memory map to build our final e820 table: > * Add regions for BIOS ranges and other special mappings not in the > hypervisor map > * Add in the hypervisor supplied regions > * Adjust the lowmem and highmem regi

Re: [Xen-devel] [v10][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-20 Thread Jan Beulich
>>> On 20.07.15 at 08:16, wrote: > +/* If there was no highmem region, just create one. */ > +if ( i == memory_map.nr_map ) > +{ > +memory_map.map[i].addr = ((uint64_t)1 << 32); > +memory_map.map[i].size = add_high_mem; > +memory_map.map[

[Xen-devel] [v10][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-19 Thread Tiejun Chen
Now use the hypervisor-supplied memory map to build our final e820 table: * Add regions for BIOS ranges and other special mappings not in the hypervisor map * Add in the hypervisor supplied regions * Adjust the lowmem and highmem regions if we've had to relocate memory (adding a highmem region