Re: [Xen-devel] [tools/libxl]: Possible bug in ao_cancel

2015-05-28 Thread Ian Jackson
Koushik Chakravarty writes ("[tools/libxl]: Possible bug in ao_cancel"): > I spotted a possible bug in ao_cancel (libxl_event.c) and wanted to run it > through you. Hi, sure. (Sorry for the delay replying, I have been away. And I'm going away again for the whole of next week...) > In the ao_ca

[Xen-devel] [tools/libxl]: Possible bug in ao_cancel

2015-05-24 Thread Koushik Chakravarty
Hi Ian, I spotted a possible bug in ao_cancel (libxl_event.c) and wanted to run it through you. In the ao_cancel(), we mark the parent->cancelling = 1 so that subsequence cancel calls don't get entertained and mess things up. However, in my view, setting this should be after we check for "paren