Re: [Xen-devel] [patch] xen/mce: fix up xen_late_init_mcelog() error handling

2015-03-16 Thread David Vrabel
On 05/03/15 11:24, Dan Carpenter wrote: > Static checkers complain about the missing call to misc_deregister() if > bind_virq_for_mce() fails. > > Also I reversed the tests so that we do error handling instead of > success handling. That way we just have a series of function calls > instead of th

Re: [Xen-devel] [patch] xen/mce: fix up xen_late_init_mcelog() error handling

2015-03-06 Thread Konrad Rzeszutek Wilk
On Thu, Mar 05, 2015 at 02:24:17PM +0300, Dan Carpenter wrote: > Static checkers complain about the missing call to misc_deregister() if > bind_virq_for_mce() fails. > > Also I reversed the tests so that we do error handling instead of > success handling. That way we just have a series of functio

[Xen-devel] [patch] xen/mce: fix up xen_late_init_mcelog() error handling

2015-03-05 Thread Dan Carpenter
Static checkers complain about the missing call to misc_deregister() if bind_virq_for_mce() fails. Also I reversed the tests so that we do error handling instead of success handling. That way we just have a series of function calls instead of the more complicated nested if statements in the origi