Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-22 Thread Stefano Stabellini
On Fri, 22 Apr 2016, Julien Grall wrote: > Hi Stefano, > > On 22/04/16 12:49, Stefano Stabellini wrote: > > On Fri, 22 Apr 2016, Julien Grall wrote: > > > Hi Jan, > > > > > > On 20/04/16 17:43, Jan Beulich wrote: > > > > > > > Julien Grall 04/20/16 2:35 PM >>> > > > > > It is a matter of taste.

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-22 Thread Julien Grall
Hi Stefano, On 22/04/16 12:49, Stefano Stabellini wrote: On Fri, 22 Apr 2016, Julien Grall wrote: Hi Jan, On 20/04/16 17:43, Jan Beulich wrote: Julien Grall 04/20/16 2:35 PM >>> It is a matter of taste. Indeed. Is there any reason to not allow different way to create a mask? I dislike

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-22 Thread Stefano Stabellini
On Fri, 22 Apr 2016, Julien Grall wrote: > Hi Jan, > > On 20/04/16 17:43, Jan Beulich wrote: > > > > > Julien Grall 04/20/16 2:35 PM >>> > > > It is a matter of taste. > > > > Indeed. > > > > > Is there any reason to not allow different way to create a mask? > > > > I dislike it, but not so mu

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-22 Thread Julien Grall
Hi Jan, On 20/04/16 17:43, Jan Beulich wrote: Julien Grall 04/20/16 2:35 PM >>> It is a matter of taste. Indeed. Is there any reason to not allow different way to create a mask? I dislike it, but not so much to stand in the way to get it in. I.e. I'm not going to NAK it, but I'm also no

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-20 Thread Jan Beulich
>>> Julien Grall 04/20/16 2:35 PM >>> >It is a matter of taste. Indeed. > Is there any reason to not allow different way to create a mask? I dislike it, but not so much to stand in the way to get it in. I.e. I'm not going to NAK it, but I'm also not currently planning to ACK it. Jan ___

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-20 Thread Julien Grall
Hi Jan, On 14/04/16 16:23, Jan Beulich wrote: Julien Grall 04/14/16 5:08 PM >>> On 14/04/16 15:56, Jan Beulich wrote: Julien Grall 04/14/16 10:55 AM >>> On 14/04/2016 05:01, Jan Beulich wrote: Julien Grall 04/13/16 6:01 PM >>> --- a/xen/include/xen/bitops.h +++ b/xen/include/xen/bitops.h

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-14 Thread Jan Beulich
>>> Julien Grall 04/14/16 5:08 PM >>> >On 14/04/16 15:56, Jan Beulich wrote: > Julien Grall 04/14/16 10:55 AM >>> >>> On 14/04/2016 05:01, Jan Beulich wrote: >>> Julien Grall 04/13/16 6:01 PM >>> > --- a/xen/include/xen/bitops.h > +++ b/xen/include/xen/bitops.h > @@ -3,6 +3,1

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-14 Thread Julien Grall
Hi Jan, On 14/04/16 15:56, Jan Beulich wrote: Julien Grall 04/14/16 10:55 AM >>> On 14/04/2016 05:01, Jan Beulich wrote: Julien Grall 04/13/16 6:01 PM >>> --- a/xen/include/xen/bitops.h +++ b/xen/include/xen/bitops.h @@ -3,6 +3,17 @@ >#include > >/* + * Create a contiguous bitma

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-14 Thread Jan Beulich
>>> Julien Grall 04/14/16 10:55 AM >>> >On 14/04/2016 05:01, Jan Beulich wrote: > Julien Grall 04/13/16 6:01 PM >>> >>> --- a/xen/include/xen/bitops.h >>> +++ b/xen/include/xen/bitops.h >>> @@ -3,6 +3,17 @@ >> >#include >> > >> >/* >>> + * Create a contiguous bitmask starting at bit po

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-14 Thread Julien Grall
Hi Jan, On 14/04/2016 05:01, Jan Beulich wrote: Julien Grall 04/13/16 6:01 PM >>> --- a/xen/include/xen/bitops.h +++ b/xen/include/xen/bitops.h @@ -3,6 +3,17 @@ >#include > >/* + * Create a contiguous bitmask starting at bit position @l and ending at + * position @h. For example + * G

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-14 Thread Julien Grall
Hi Andrew, On 13/04/2016 19:14, Andrew Cooper wrote: On 13/04/16 16:55, Julien Grall wrote: The code has been imported from the header include/linux/bitops.h in Linux v4.6-rc3. Signed-off-by: Julien Grall --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- xen/includ

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-13 Thread Jan Beulich
>>> Julien Grall 04/13/16 6:01 PM >>> >--- a/xen/include/xen/bitops.h >+++ b/xen/include/xen/bitops.h >@@ -3,6 +3,17 @@ >#include > >/* >+ * Create a contiguous bitmask starting at bit position @l and ending at >+ * position @h. For example >+ * GENMASK_ULL(39, 21) gives us the 64bit vector 0x

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-13 Thread Andrew Cooper
On 13/04/16 16:55, Julien Grall wrote: > The code has been imported from the header include/linux/bitops.h in > Linux v4.6-rc3. > > Signed-off-by: Julien Grall > > --- > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Keir Fraser > Cc: Tim Deegan > --- > xen/include/xen/bitops.h | 11 +++ > 1

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-13 Thread Stefano Stabellini
On Wed, 13 Apr 2016, Julien Grall wrote: > The code has been imported from the header include/linux/bitops.h in > Linux v4.6-rc3. > > Signed-off-by: Julien Grall Acked-by: Stefano Stabellini > --- > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Keir Fraser > Cc: Tim Deegan > xen/include/xen/bi

[Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-13 Thread Julien Grall
The code has been imported from the header include/linux/bitops.h in Linux v4.6-rc3. Signed-off-by: Julien Grall --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- xen/include/xen/bitops.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/xen/include/xen/b