Re: [Xen-devel] [XEN VMID PATCH 2/2 v4] xen/arm: Add support for 16 bit VMIDs

2016-12-15 Thread Julien Grall
Hi Bhupinder, On 15/12/16 11:23, Bhupinder Thakur wrote:. + * VMIDs. + */ +if ( !vmid_8_bit ) +max_vmid = MAX_VMID_16_BIT; + /* pa_range is 4 bits, but the defined encodings are only 3 bits */ if ( pa_range&0x8 || !pa_range_info[pa_range].pabits ) panic("

Re: [Xen-devel] [XEN VMID PATCH 2/2 v4] xen/arm: Add support for 16 bit VMIDs

2016-12-15 Thread Bhupinder Thakur
Hi Julien, On 15 December 2016 at 16:00, Julien Grall wrote: > Hi Bhupinder, > > On 15/12/16 06:13, Bhupinder Thakur wrote: >> >> + >> +/* set a flag if the current cpu does not suppot 16 bit VMIDs */ >> +if ( info->mm64.vmid_bits != MM64_VMID_16_BITS_SUPPORT ) >> +v

Re: [Xen-devel] [XEN VMID PATCH 2/2 v4] xen/arm: Add support for 16 bit VMIDs

2016-12-15 Thread Bhupinder Thakur
Hi Julien, >> -#define MAX_VMID 256 >> -#define INVALID_VMID 0 /* VMID 0 is reserved */ >> >> static spinlock_t vmid_alloc_lock = SPIN_LOCK_UNLOCKED; >> >> /* >> - * VTTBR_EL2 VMID field is 8 bits. Using a bitmap here limits us to >> - * 256 concurrent domains. >> + * VTTBR_EL2 VMID field is 8

Re: [Xen-devel] [XEN VMID PATCH 2/2 v4] xen/arm: Add support for 16 bit VMIDs

2016-12-15 Thread Julien Grall
Hi Bhupinder, On 15/12/16 06:13, Bhupinder Thakur wrote: + +/* set a flag if the current cpu does not suppot 16 bit VMIDs */ +if ( info->mm64.vmid_bits != MM64_VMID_16_BITS_SUPPORT ) +vmid_8_bit = true; } +/* I just spot a trailing white space here while t

Re: [Xen-devel] [XEN VMID PATCH 2/2 v4] xen/arm: Add support for 16 bit VMIDs

2016-12-15 Thread Julien Grall
Hi Bhupinder, On 15/12/16 06:13, Bhupinder Thakur wrote: VMID space is increased to 16-bits from 8-bits in ARMv8 8.1 revision. This allows more than 256 VMs to be supported by Xen. This change adds support for 16-bit VMIDs in Xen based on whether the architecture supports it. Signed-off-by: Bh

[Xen-devel] [XEN VMID PATCH 2/2 v4] xen/arm: Add support for 16 bit VMIDs

2016-12-14 Thread Bhupinder Thakur
VMID space is increased to 16-bits from 8-bits in ARMv8 8.1 revision. This allows more than 256 VMs to be supported by Xen. This change adds support for 16-bit VMIDs in Xen based on whether the architecture supports it. Signed-off-by: Bhupinder Thakur --- xen/arch/arm/p2m.c | 45 ++