Re: [Xen-devel] [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS commands support

2015-07-03 Thread Ian Campbell
On Fri, 2015-07-03 at 12:20 +0530, Vijay Kilari wrote: > On Mon, Jun 29, 2015 at 5:53 PM, Ian Campbell wrote: > > On Mon, 2015-06-22 at 17:31 +0530, vijay.kil...@gmail.com wrote: > >> +static int vgic_its_process_mapvi(struct vcpu *v, struct vgic_its *vits, > >> +

Re: [Xen-devel] [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS commands support

2015-07-02 Thread Vijay Kilari
On Mon, Jun 29, 2015 at 5:53 PM, Ian Campbell wrote: > On Mon, 2015-06-22 at 17:31 +0530, vijay.kil...@gmail.com wrote: >> +static int vgic_its_process_mapvi(struct vcpu *v, struct vgic_its *vits, >> + its_cmd_block *virt_cmd) >> +{ >> +struct vitt entry; >> +

Re: [Xen-devel] [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS commands support

2015-06-29 Thread Ian Campbell
On Mon, 2015-06-22 at 17:31 +0530, vijay.kil...@gmail.com wrote: > +static int vgic_its_process_mapvi(struct vcpu *v, struct vgic_its *vits, > + its_cmd_block *virt_cmd) > +{ > +struct vitt entry; > +struct vits_device *vdev; > +uint8_t vcol_id, cmd; > +

Re: [Xen-devel] [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS commands support

2015-06-29 Thread Ian Campbell
On Mon, 2015-06-22 at 17:31 +0530, vijay.kil...@gmail.com wrote: [...] > +/* XXX: Enable validation later */ > +vdev = find_vits_device(&v->domain->arch.vits->dev_root, dev_id); > +if ( !vdev && !vdev->its_dev ) > +return -EINVAL; vdev is unused I think. Which is good because a

Re: [Xen-devel] [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS commands support

2015-06-29 Thread Ian Campbell
On Wed, 2015-06-24 at 11:29 +0100, Julien Grall wrote: > > +if ( virt_cmd->mapd.valid ) > > +{ > > +/* itt field is 40 bit. extract 48 bit address by shifting */ > > +dt_entry.vitt_ipa = virt_cmd->mapd.itt << 8; > > + > > +dt_entry.vitt_size = (1 << (virt_cmd->mapd.

Re: [Xen-devel] [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS commands support

2015-06-24 Thread Julien Grall
Hi Vijay, On 22/06/15 13:01, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > Add Virtual ITS command processing support to Virtual ITS driver > > Signed-off-by: Vijaya Kumar K > --- > xen/arch/arm/gic-v3-its.c |7 + > xen/arch/arm/vgic-v3-its.c | 393 >

[Xen-devel] [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS commands support

2015-06-22 Thread vijay . kilari
From: Vijaya Kumar K Add Virtual ITS command processing support to Virtual ITS driver Signed-off-by: Vijaya Kumar K --- xen/arch/arm/gic-v3-its.c |7 + xen/arch/arm/vgic-v3-its.c | 393 2 files changed, 400 insertions(+) diff --git a/xen/arch