Re: [Xen-devel] [RFC PATCH v2] Data integrity extension(DIX) support for xen-block

2016-04-20 Thread David Vrabel
On 20/04/16 13:08, Bob Liu wrote: > > > The "feature-data-integrity" could be extended to "unsigned int" instead of > "bool", > so as to report all DIX formats backend supports. I think it would be preferable to have something string based. I think Linux reports the formats using a string enco

Re: [Xen-devel] [RFC PATCH v2] Data integrity extension(DIX) support for xen-block

2016-04-20 Thread Bob Liu
On 04/20/2016 04:59 PM, David Vrabel wrote: > On 20/04/16 08:26, Bob Liu wrote: >> >> /* >> + * Recognized only if "feature-data-integrity" is present in backend xenbus >> info. >> + * A request with BLKIF_OP_DIX_FLAG indicates the following request is a >> special >> + * request which only con

Re: [Xen-devel] [RFC PATCH v2] Data integrity extension(DIX) support for xen-block

2016-04-20 Thread David Vrabel
On 20/04/16 08:26, Bob Liu wrote: > > /* > + * Recognized only if "feature-data-integrity" is present in backend xenbus > info. > + * A request with BLKIF_OP_DIX_FLAG indicates the following request is a > special > + * request which only contains integrity-metadata segments of current > reque

[Xen-devel] [RFC PATCH v2] Data integrity extension(DIX) support for xen-block

2016-04-20 Thread Bob Liu
* What's data integrity extension(DIX) and why? Modern filesystems feature checksumming of data and metadata to protect against data corruption. However, the detection of the corruption is done at read time which could potentially be months after the data was written. At that point the original d