Re: [Xen-devel] [RFC PATCH V3 2/3] Tool/ACPI: DSDT extension to support more vcpus

2017-09-19 Thread Roger Pau Monné
On Tue, Sep 19, 2017 at 09:02:06AM -0600, Jan Beulich wrote: > >>> On 19.09.17 at 16:13, wrote: > > We need to be careful to not create local APIC entries with either > > APIC or ACPI ID equal to 255 (and to also not create Processor objects > > with ACPI ID of 255). > > Why? An ACPI or APIC ID i

Re: [Xen-devel] [RFC PATCH V3 2/3] Tool/ACPI: DSDT extension to support more vcpus

2017-09-19 Thread Jan Beulich
>>> On 19.09.17 at 16:13, wrote: > On Tue, Sep 19, 2017 at 07:55:32AM -0600, Jan Beulich wrote: >> >>> On 19.09.17 at 15:48, wrote: >> > On Tue, Sep 19, 2017 at 07:44:21AM -0600, Jan Beulich wrote: >> >> >>> On 19.09.17 at 15:29, wrote: >> >> > On Wed, Sep 13, 2017 at 12:52:48AM -0400, Lan Tiany

Re: [Xen-devel] [RFC PATCH V3 2/3] Tool/ACPI: DSDT extension to support more vcpus

2017-09-19 Thread Roger Pau Monné
On Tue, Sep 19, 2017 at 07:55:32AM -0600, Jan Beulich wrote: > >>> On 19.09.17 at 15:48, wrote: > > On Tue, Sep 19, 2017 at 07:44:21AM -0600, Jan Beulich wrote: > >> >>> On 19.09.17 at 15:29, wrote: > >> > On Wed, Sep 13, 2017 at 12:52:48AM -0400, Lan Tianyu wrote: > >> >> +if ( apic_id >

Re: [Xen-devel] [RFC PATCH V3 2/3] Tool/ACPI: DSDT extension to support more vcpus

2017-09-19 Thread Jan Beulich
>>> On 19.09.17 at 15:48, wrote: > On Tue, Sep 19, 2017 at 07:44:21AM -0600, Jan Beulich wrote: >> >>> On 19.09.17 at 15:29, wrote: >> > On Wed, Sep 13, 2017 at 12:52:48AM -0400, Lan Tianyu wrote: >> >> +if ( apic_id > 254 ) >> > >> > 255? An APIC ID of 255 should still be fine. >> >> W

Re: [Xen-devel] [RFC PATCH V3 2/3] Tool/ACPI: DSDT extension to support more vcpus

2017-09-19 Thread Roger Pau Monné
On Tue, Sep 19, 2017 at 07:44:21AM -0600, Jan Beulich wrote: > >>> On 19.09.17 at 15:29, wrote: > > On Wed, Sep 13, 2017 at 12:52:48AM -0400, Lan Tianyu wrote: > >> +if ( apic_id > 254 ) > > > > 255? An APIC ID of 255 should still be fine. > > Wasn't it you who (validly) asked for the bo

Re: [Xen-devel] [RFC PATCH V3 2/3] Tool/ACPI: DSDT extension to support more vcpus

2017-09-19 Thread Jan Beulich
>>> On 19.09.17 at 15:29, wrote: > On Wed, Sep 13, 2017 at 12:52:48AM -0400, Lan Tianyu wrote: >> +if ( apic_id > 254 ) > > 255? An APIC ID of 255 should still be fine. Wasn't it you who (validly) asked for the boundary to be 254, due to 0xff being the broadcast value? Jan ___

Re: [Xen-devel] [RFC PATCH V3 2/3] Tool/ACPI: DSDT extension to support more vcpus

2017-09-19 Thread Roger Pau Monné
On Wed, Sep 13, 2017 at 12:52:48AM -0400, Lan Tianyu wrote: > This patch is to change DSDT table for processor object to support >128 vcpus > accroding to ACPI spec 8.4 Declaring Processors > > Signed-off-by: Lan Tianyu > --- > tools/libacpi/mk_dsdt.c | 31 +-- > 1 fi

[Xen-devel] [RFC PATCH V3 2/3] Tool/ACPI: DSDT extension to support more vcpus

2017-09-13 Thread Lan Tianyu
This patch is to change DSDT table for processor object to support >128 vcpus accroding to ACPI spec 8.4 Declaring Processors Signed-off-by: Lan Tianyu --- tools/libacpi/mk_dsdt.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/tools/libacpi/m