Re: [Xen-devel] [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-05 Thread Tamas K Lengyel
On Tue, Feb 3, 2015 at 10:17 AM, Jan Beulich wrote: On 02.02.15 at 18:19, wrote: >> On Thu, 2015-01-29 at 22:46 +0100, Tamas K Lengyel wrote: >>> +union { >>> +struct mem_event_paging_datamem_paging; >>> +struct mem_event_sharing_data mem_sha

Re: [Xen-devel] [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-05 Thread Tamas K Lengyel
On Mon, Feb 2, 2015 at 6:19 PM, Ian Campbell wrote: > On Thu, 2015-01-29 at 22:46 +0100, Tamas K Lengyel wrote: >> From: Razvan Cojocaru >> >> The public mem_event structures used to communicate with helper applications >> via >> shared rings have been used in different settings. However, the va

Re: [Xen-devel] [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-03 Thread Jan Beulich
>>> On 29.01.15 at 22:46, wrote: > +static int hvm_memory_event_traps(long parameters, mem_event_request_t *req) It looks like parameters isn't really a signed quantity... > void hvm_memory_event_cr0(unsigned long value, unsigned long old) > { > -hvm_memory_event_traps(current->domain->ar

Re: [Xen-devel] [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-03 Thread Jan Beulich
>>> On 02.02.15 at 18:19, wrote: > On Thu, 2015-01-29 at 22:46 +0100, Tamas K Lengyel wrote: >> +union { >> +struct mem_event_paging_datamem_paging; >> +struct mem_event_sharing_data mem_sharing; >> +struct mem_event_mem_access_data

Re: [Xen-devel] [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-02 Thread Ian Campbell
On Thu, 2015-01-29 at 22:46 +0100, Tamas K Lengyel wrote: > From: Razvan Cojocaru > > The public mem_event structures used to communicate with helper applications > via > shared rings have been used in different settings. However, the variable names > within this structure have not reflected thi

[Xen-devel] [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures

2015-01-29 Thread Tamas K Lengyel
From: Razvan Cojocaru The public mem_event structures used to communicate with helper applications via shared rings have been used in different settings. However, the variable names within this structure have not reflected this fact, resulting in the reuse of variables to mean different things un