Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-29 Thread Tamas K Lengyel
On Thu, Jan 29, 2015 at 1:51 PM, Jan Beulich wrote: On 29.01.15 at 13:09, wrote: >> The reason why compilation fails is because the new preprocessor check >> in mem_event.j #if !defined(__XEN__) && !defined(__XEN_TOOLS__) is not >> happy and I get the error message #error "vm event operation

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-29 Thread Jan Beulich
>>> On 29.01.15 at 13:09, wrote: > The reason why compilation fails is because the new preprocessor check > in mem_event.j #if !defined(__XEN__) && !defined(__XEN_TOOLS__) is not > happy and I get the error message #error "vm event operations are > intended for use only by Xen or node control tool

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-29 Thread Tamas K Lengyel
On Thu, Jan 29, 2015 at 1:09 PM, Tamas K Lengyel wrote: > On Thu, Jan 29, 2015 at 1:02 PM, Jan Beulich wrote: > On 29.01.15 at 12:54, wrote: >>> On Thu, Jan 22, 2015 at 4:34 PM, Tamas K Lengyel >>> wrote: On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich wrote: On 18.01.15 at 16:1

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-29 Thread Tamas K Lengyel
On Thu, Jan 29, 2015 at 1:02 PM, Jan Beulich wrote: On 29.01.15 at 12:54, wrote: >> On Thu, Jan 22, 2015 at 4:34 PM, Tamas K Lengyel >> wrote: >>> On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich wrote: >>> On 18.01.15 at 16:17, wrote: > --- a/xen/include/Makefile > +++ b/xen/incl

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-29 Thread Jan Beulich
>>> On 29.01.15 at 12:54, wrote: > On Thu, Jan 22, 2015 at 4:34 PM, Tamas K Lengyel > wrote: >> On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich wrote: >> On 18.01.15 at 16:17, wrote: --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH)

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-29 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 4:34 PM, Tamas K Lengyel wrote: > On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich wrote: > On 18.01.15 at 16:17, wrote: >>> --- a/xen/include/Makefile >>> +++ b/xen/include/Makefile >>> @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH)) >>> >>> all: headers

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-23 Thread Tamas K Lengyel
On Fri, Jan 23, 2015 at 10:00 AM, Jan Beulich wrote: > (re-adding xen-devel) > On 22.01.15 at 17:54, wrote: >> On Thu, Jan 22, 2015 at 5:34 PM, Jan Beulich wrote: >> On 22.01.15 at 17:23, wrote: Wouldn't making the struct packed just take care of it automatically? >>> >>> How

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-23 Thread Jan Beulich
(re-adding xen-devel) >>> On 22.01.15 at 17:54, wrote: > On Thu, Jan 22, 2015 at 5:34 PM, Jan Beulich wrote: > On 22.01.15 at 17:23, wrote: >>> Wouldn't making the >>> struct packed just take care of it automatically? >> >> How would you envision to do that without using compiler >> extensi

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Jan Beulich
>>> On 22.01.15 at 17:23, wrote: > On Thu, Jan 22, 2015 at 5:00 PM, Jan Beulich wrote: > On 22.01.15 at 16:34, wrote: >>> On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich wrote: >>> On 18.01.15 at 16:17, wrote: > --- a/xen/include/public/mem_event.h > +++ b/xen/include/public/mem_e

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 5:00 PM, Jan Beulich wrote: On 22.01.15 at 16:34, wrote: >> On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich wrote: >> On 18.01.15 at 16:17, wrote: --- a/xen/include/public/mem_event.h +++ b/xen/include/public/mem_event.h @@ -27,9 +27,15 @@ #ifn

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Jan Beulich
>>> On 22.01.15 at 16:34, wrote: > On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich wrote: > On 18.01.15 at 16:17, wrote: >>> --- a/xen/include/public/mem_event.h >>> +++ b/xen/include/public/mem_event.h >>> @@ -27,9 +27,15 @@ >>> #ifndef _XEN_PUBLIC_MEM_EVENT_H >>> #define _XEN_PUBLIC_MEM_EVE

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 4:00 PM, Jan Beulich wrote: On 18.01.15 at 16:17, wrote: >> --- a/xen/include/Makefile >> +++ b/xen/include/Makefile >> @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH)) >> >> all: headers.chk >> >> -headers.chk: $(filter-out public/arch-% public/%ctl.h

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Jan Beulich
>>> On 18.01.15 at 16:17, wrote: > --- a/xen/include/Makefile > +++ b/xen/include/Makefile > @@ -90,7 +90,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH)) > > all: headers.chk > > -headers.chk: $(filter-out public/arch-% public/%ctl.h public/xsm/% > public/%hvm/save.h, $(wildcard public/*.

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Tim Deegan
At 13:50 +0100 on 22 Jan (1421931059), Tamas K Lengyel wrote: > On Thu, Jan 22, 2015 at 1:43 PM, Tim Deegan wrote: > >> -rsp.gfn = req.gfn; > >> -rsp.p2mt = req.p2mt; > >> +rsp.mem_access_event.gfn = req.mem_access_event.gfn; > > > > You're dropping

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Razvan Cojocaru
On 01/22/2015 02:50 PM, Tamas K Lengyel wrote: > On Thu, Jan 22, 2015 at 1:43 PM, Tim Deegan wrote: >> Hi, >> >> At 16:17 +0100 on 18 Jan (1421594274), Tamas K Lengyel wrote: >>> From: Razvan Cojocaru >>> >>> The public mem_event structures used to communicate with helper >>> applications via >>

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Razvan Cojocaru
On 01/22/2015 02:43 PM, Tim Deegan wrote: > Hi, > > At 16:17 +0100 on 18 Jan (1421594274), Tamas K Lengyel wrote: >> From: Razvan Cojocaru >> >> The public mem_event structures used to communicate with helper applications >> via >> shared rings have been used in different settings. However, the

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Tamas K Lengyel
On Thu, Jan 22, 2015 at 1:43 PM, Tim Deegan wrote: > Hi, > > At 16:17 +0100 on 18 Jan (1421594274), Tamas K Lengyel wrote: >> From: Razvan Cojocaru >> >> The public mem_event structures used to communicate with helper applications >> via >> shared rings have been used in different settings. Howe

Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-22 Thread Tim Deegan
Hi, At 16:17 +0100 on 18 Jan (1421594274), Tamas K Lengyel wrote: > From: Razvan Cojocaru > > The public mem_event structures used to communicate with helper applications > via > shared rings have been used in different settings. However, the variable names > within this structure have not refl

[Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

2015-01-18 Thread Tamas K Lengyel
From: Razvan Cojocaru The public mem_event structures used to communicate with helper applications via shared rings have been used in different settings. However, the variable names within this structure have not reflected this fact, resulting in the reuse of variables to mean different things un