Re: [Xen-devel] [RFC PATCH COLO v5 02/29] Refactor domain_suspend_callback_common()

2015-04-22 Thread Ian Campbell
On Wed, 2015-04-01 at 14:41 +0800, Yang Hongyang wrote: > The core function to suspend vm is domain_suspend_callback_common(). > So use a new structure libxl__domain_suspend_state2 to > instead of libxl__domain_suspend_state. The dss's members that > will be used in domain_suspend_callback_common()

Re: [Xen-devel] [RFC PATCH COLO v5 02/29] Refactor domain_suspend_callback_common()

2015-04-13 Thread Wen Congyang
On 04/09/2015 02:11 AM, Wei Liu wrote: > On Wed, Apr 01, 2015 at 02:41:38PM +0800, Yang Hongyang wrote: >> From: Wen Congyang >> >> libxl__domain_suspend() is to save the guest. I think >> we should call it libxl__domain_save(), but I don't >> rename it. >> > > FWIW this is not public API so we h

Re: [Xen-devel] [RFC PATCH COLO v5 02/29] Refactor domain_suspend_callback_common()

2015-04-08 Thread Wei Liu
On Wed, Apr 01, 2015 at 02:41:38PM +0800, Yang Hongyang wrote: > From: Wen Congyang > > libxl__domain_suspend() is to save the guest. I think > we should call it libxl__domain_save(), but I don't > rename it. > FWIW this is not public API so we have certain degree of liberty to rename it if the

[Xen-devel] [RFC PATCH COLO v5 02/29] Refactor domain_suspend_callback_common()

2015-03-31 Thread Yang Hongyang
From: Wen Congyang libxl__domain_suspend() is to save the guest. I think we should call it libxl__domain_save(), but I don't rename it. Secondary vm is running in colo mode. So we will do the following things again and again: 1. suspend both primay vm and secondary vm 2. sync the state 3. resume