Re: [Xen-devel] [RFC PATCH 05/24] ARM: GICv3 ITS: introduce ITS command handling

2017-01-31 Thread Julien Grall
Hi Andre, On 31/01/2017 09:10, Andre Przywara wrote: On 02/11/16 15:05, Julien Grall wrote: On 28/09/16 19:24, Andre Przywara wrote: +} + +static uint64_t encode_rdbase(struct host_its *hw_its, int cpu, uint64_t reg) +{ +reg &= ~GENMASK(51, 16); + +if ( hw_its->pta ) +reg |= pe

Re: [Xen-devel] [RFC PATCH 05/24] ARM: GICv3 ITS: introduce ITS command handling

2017-01-31 Thread Andre Przywara
Hi Julien, (forgot to hit the Send button yesterday ...) just going over the review comments again and found some leftovers. I fixed/addressed all comments of yours that I don't explicitly refer to here. ... On 02/11/16 15:05, Julien Grall wrote: > Hi Andre, > > On 28/09/16 19:24, Andre Przywa

Re: [Xen-devel] [RFC PATCH 05/24] ARM: GICv3 ITS: introduce ITS command handling

2016-11-10 Thread Andre Przywara
Hi, On 27/10/16 00:55, Stefano Stabellini wrote: > On Wed, 28 Sep 2016, Andre Przywara wrote: >> To be able to easily send commands to the ITS, create the respective >> wrapper functions, which take care of the ring buffer. >> The first two commands we implement provide methods to map a collection

Re: [Xen-devel] [RFC PATCH 05/24] ARM: GICv3 ITS: introduce ITS command handling

2016-11-02 Thread Julien Grall
Hi Andre, On 28/09/16 19:24, Andre Przywara wrote: To be able to easily send commands to the ITS, create the respective wrapper functions, which take care of the ring buffer. The first two commands we implement provide methods to map a collection to a redistributor (aka host core) and to flush t

Re: [Xen-devel] [RFC PATCH 05/24] ARM: GICv3 ITS: introduce ITS command handling

2016-10-27 Thread Stefano Stabellini
On Wed, 26 Oct 2016, Stefano Stabellini wrote: > > +/* ITS command definitions */ > > +#define ITS_CMD_SIZE32 > > + > > +#define GITS_CMD_MOVI 0x01 > > +#define GITS_CMD_INT0x03 > > +#define GITS_CMD_CLEAR 0x04 > > +#define

Re: [Xen-devel] [RFC PATCH 05/24] ARM: GICv3 ITS: introduce ITS command handling

2016-10-26 Thread Stefano Stabellini
On Wed, 28 Sep 2016, Andre Przywara wrote: > To be able to easily send commands to the ITS, create the respective > wrapper functions, which take care of the ring buffer. > The first two commands we implement provide methods to map a collection > to a redistributor (aka host core) and to flush the

[Xen-devel] [RFC PATCH 05/24] ARM: GICv3 ITS: introduce ITS command handling

2016-09-28 Thread Andre Przywara
To be able to easily send commands to the ITS, create the respective wrapper functions, which take care of the ring buffer. The first two commands we implement provide methods to map a collection to a redistributor (aka host core) and to flush the command queue (SYNC). Start using these commands fo