Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-09-21 Thread Julien Grall
Hi Sameer, On 21/09/17 01:37, Goel, Sameer wrote: [...] diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index 995a85a..3785fae 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -9,7 +9,12 @@ #include #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-09-20 Thread Goel, Sameer
On 9/12/2017 5:25 AM, Julien Grall wrote: > Hi Sameer, > > On 28/08/17 23:21, Goel, Sameer wrote: >> On 6/12/2017 7:24 AM, Julien Grall wrote:   static int arm_smmu_iort_xlate(struct device *dev, u32 streamid, struct fwnode_handle *fwnode,

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-09-12 Thread Julien Grall
Hi Sameer, On 28/08/17 23:21, Goel, Sameer wrote: On 6/12/2017 7:24 AM, Julien Grall wrote: static int arm_smmu_iort_xlate(struct device *dev, u32 streamid, struct fwnode_handle *fwnode, const struct iommu_ops *ops) @@ -523,29 +563,24 @@ static int ar

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-08-28 Thread Goel, Sameer
On 6/12/2017 7:24 AM, Julien Grall wrote: > Hi Sameer, > > On 08/06/17 20:30, Sameer Goel wrote: >> Add limited support for parsing IORT table to initialize SMMU devices. > > It would be nice to explain what you actually support in the commit message. > > [...] > >> >>  #define IORT_TYPE_MASK

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-08-28 Thread Goel, Sameer
On 6/9/2017 5:15 AM, Robin Murphy wrote: > On 08/06/17 20:30, Sameer Goel wrote: > [...] >> /** >> - * iort_iommu_configure - Set-up IOMMU configuration for a device. >> + * iort_iommu_configure - Set-up IOMMU configuration for a device. This >> + * function sets up the fwspec as needed for a gi

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-07-14 Thread Jan Beulich
>>> On 08.06.17 at 21:30, wrote: > Add limited support for parsing IORT table to initialize SMMU devices. > > Signed-off-by: Sameer Goel > --- > xen/arch/arm/setup.c| 3 + > xen/drivers/acpi/Makefile | 1 + > xen/drivers/acpi/arm/Makefile | 1 + > xen/drive

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-06-21 Thread Robin Murphy
On 12/06/17 14:44, Jan Beulich wrote: On 12.06.17 at 15:36, wrote: >> On 09/06/17 12:15, Robin Murphy wrote: >>> On 08/06/17 20:30, Sameer Goel wrote: >>> [...] /** - * iort_iommu_configure - Set-up IOMMU configuration for a device. + * iort_iommu_configure - Set-up IOMMU conf

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 15:36, wrote: > On 09/06/17 12:15, Robin Murphy wrote: >> On 08/06/17 20:30, Sameer Goel wrote: >> [...] >>> /** >>> - * iort_iommu_configure - Set-up IOMMU configuration for a device. >>> + * iort_iommu_configure - Set-up IOMMU configuration for a device. This >>> + * function

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-06-12 Thread Julien Grall
(CC x86 folks) Hi, On 09/06/17 12:15, Robin Murphy wrote: On 08/06/17 20:30, Sameer Goel wrote: [...] /** - * iort_iommu_configure - Set-up IOMMU configuration for a device. + * iort_iommu_configure - Set-up IOMMU configuration for a device. This + * function sets up the fwspec as needed for

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-06-12 Thread Julien Grall
Hi Sameer, On 08/06/17 20:30, Sameer Goel wrote: Add limited support for parsing IORT table to initialize SMMU devices. It would be nice to explain what you actually support in the commit message. [...] #define IORT_TYPE_MASK(type) (1 << (type)) #define IORT_MSI_TYPE (1 << ACP

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-06-09 Thread Robin Murphy
On 08/06/17 20:30, Sameer Goel wrote: [...] > /** > - * iort_iommu_configure - Set-up IOMMU configuration for a device. > + * iort_iommu_configure - Set-up IOMMU configuration for a device. This > + * function sets up the fwspec as needed for a given device. Only PCI > + * devices are supported fo

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-06-08 Thread Stefano Stabellini
CCing Jan On Thu, 8 Jun 2017, Sameer Goel wrote: > Add limited support for parsing IORT table to initialize SMMU devices. > > Signed-off-by: Sameer Goel > --- > xen/arch/arm/setup.c| 3 + > xen/drivers/acpi/Makefile | 1 + > xen/drivers/acpi/arm/Makefile |

[Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-06-08 Thread Sameer Goel
Add limited support for parsing IORT table to initialize SMMU devices. Signed-off-by: Sameer Goel --- xen/arch/arm/setup.c| 3 + xen/drivers/acpi/Makefile | 1 + xen/drivers/acpi/arm/Makefile | 1 + xen/drivers/acpi/arm/iort.c | 232 +